This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Various improvements #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A missing echo line was causing incomplete HTML to be returned.
- get the json data - reformat it to match the TimelineJS format - create a timeline instance
- Refactor to provide function to create an end date - The end date currently does not work and is commented out, along with various logs for debugging - If the record has a file, it is returned in the json with the image key. Take what is there and include it in the slide.
- Remove the old code that created the Simile timeline - Remove old center date code - Make the title of each record's slide a link to the Omeka record
…ing multiple timelines on a single page
The theme-config setting for loading javascripts locally has changed from InternalJavascripts to InternalAssets, to recognize that people will want to use this for css files and such as well. I updated the plugin to accept the old or new syntax.
|
Hey, This is all awesome. This week has also been crazy, so I have had a chance to do more than glance at your pull requests. I'll check them out more thoroughly next week, though. Thanks, |
Daniel-KM
force-pushed
the
various_improvements
branch
from
68e59ca to
8ca43ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These commits are new fixes and improvements (in particular #78, #76, #75, #66, #63, #57 and #48).
Especially, an option is added to manage single years (as date or as period), the elements can be set at the timeline level, and a new parameter is added for the end date. Furthermore, this is easy now to add new parameters without change the database. The upgrade is automatic from previous releases.
Sincerely,
Daniel Berthereau
Infodoc & Knowledge management