Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added history, flash, trailor #829

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

gokberknur
Copy link
Collaborator

Describe pull-request

Adding 3 icons into tegel pacakge, that exist in industrial icons (in the figma-ui kit)

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to Icons page in storybook
  2. Check the icons that added in this PR
  3. Use them

Checklist before submission

  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Include before/after screenshots for UI changes.

Additional context

Add any other context or feedback requests about the pull-request here.

Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Playwright test results

passed  390 passed
skipped  1 skipped

Details

stats  391 tests across 132 suites
duration  54.5 seconds
commit  fbca28e

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-829.d3fazya28914g3.amplifyapp.com

@theJohnnyMe theJohnnyMe changed the title Feature/adding more icons feat(icons): added history, flash, trailor Nov 6, 2024
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for a contribution! LGTM!

Copy link
Contributor

@timrombergjakobsson timrombergjakobsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution @gokberknur!

Copy link
Contributor

@mistermalm mistermalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@theJohnnyMe theJohnnyMe merged commit 7ff671d into develop Nov 6, 2024
3 checks passed
@theJohnnyMe theJohnnyMe deleted the feature/adding_more_icons branch November 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants