Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): fullbleed 100% rule #702

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

theJohnnyMe
Copy link
Contributor

@theJohnnyMe theJohnnyMe commented Jul 26, 2024

Describe pull-request

Small fix to full bleed button.

Issue Linking:

  • Jira: Add ticket number after CDEP-: CDEP-1261

How to test

  1. Go to the preview link
  2. Check button with full bleed rule
  3. There should be no changes in the behavior

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Include before/after screenshots for UI changes.

Additional context

Add any other context or feedback requests about the pull-request here.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Playwright test results

passed  343 passed

Details

stats  343 tests across 101 suites
duration  45.9 seconds
commit  39ae6a8

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-702.d3fazya28914g3.amplifyapp.com

Copy link

@theJohnnyMe theJohnnyMe merged commit bb60ed2 into develop Jul 29, 2024
3 checks passed
@theJohnnyMe theJohnnyMe deleted the fix/CDEP-1261-button-width branch July 29, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants