Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/SK-1462 | Add Combiner DTO #832

Open
wants to merge 2 commits into
base: feature/SK-1434
Choose a base branch
from
Open

Feature/SK-1462 | Add Combiner DTO #832

wants to merge 2 commits into from

Conversation

carl-andersson
Copy link
Contributor

  • Converted Combiner store to use DTO for transactions to the database
  • Added tests for Combinerstore

@github-actions github-actions bot added minor feature New feature or request labels Mar 3, 2025
@carl-andersson carl-andersson marked this pull request as ready for review March 3, 2025 14:22
niklastheman
niklastheman approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@niklastheman niklastheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have one question but approved anyhow...

fedn/network/storage/statestore/stores/combiner_store.py


class SQLCombinerStore(CombinerStore, SQLStore[Combiner]):
class SQLCombinerStore(CombinerStore, SQLStore[CombinerDTO]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the get_by_name method? Is this solved in another way? If so great, we should remove get_by_name from the interface...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be there? It is a new method, so added it to both mongo and sql. I believe it is required but could be discussed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Yes, I think in the future we can think of removing it... Name should not be used as key I think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklastheman niklastheman niklastheman approved these changes

@Wrede Wrede Awaiting requested review from Wrede

Assignees
No one assigned
Labels
feature New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-andersson @niklastheman