Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/SK-1452 | GrpcConnectionOptions all args not needed for direct combiner connection #823

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Feb 26, 2025

GRPCConnectionOptions returned missing constructor arguments error when connecting directly to combiner without service discovery at controller, i.e --combiner and --combiner-port in CLI.

Copy link
Contributor

@benjaminastrand benjaminastrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Wrede Wrede merged commit 2aca3cb into master Feb 26, 2025
21 checks passed
@Wrede Wrede deleted the bugfix/SK-1452 branch February 26, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants