Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move warnings to useEffect #1016

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Move warnings to useEffect #1016

merged 1 commit into from
Dec 18, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Dec 17, 2024

Without this we show warnings on every render so all the console is yellow, try example from #1015

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this Rinat! It was a bit annoying hah

For the write hook, maybe it would be better to show a warning everytime we execute the writeContractAsync?

@rin-st
Copy link
Member Author

rin-st commented Dec 18, 2024

For the write hook, maybe it would be better to show a warning everytime we execute the writeContractAsync?

I'm not sure. Yes, if we want to make it very annoying

But I'm tending not to change it since devs already see one console message for every hook. And the amount of executions is not correlating with amount of places to change.

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rin-st!!

@technophile-04 technophile-04 merged commit 24fe055 into main Dec 18, 2024
1 check passed
@technophile-04 technophile-04 deleted the move-warnings-to-useEffect branch December 18, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants