Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for global variable creation #2913

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jun 17, 2019

@xzyfer xzyfer merged commit 031b2b5 into sass:master Feb 19, 2020
@mgreter
Copy link
Contributor Author

mgreter commented Feb 26, 2020

This change needs a spec update for spec/libsass-closed-issues/issue_2520

@nex3
Copy link
Contributor

nex3 commented Feb 28, 2020

This is breaking sass-spec: https://travis-ci.org/sass/sass-spec/jobs/656073334

In the future, please land PRs that require spec updates concurrently with PRs that update sass-spec.

nex3 added a commit to sass/sass-spec that referenced this pull request Feb 28, 2020
nex3 added a commit to sass/sass-spec that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants