Skip to content

Commit

Permalink
Update pull_request_template.md (#40)
Browse files Browse the repository at this point in the history
closes #36
  • Loading branch information
rheone authored and ahsteele committed Nov 11, 2019
1 parent 9d7b20f commit 5b85846
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ Hello, and welcome! Thanks you for your contribution to **Gulliver**.
- [ ] Does it fix a bug?
- [ ] Does it add new functionality?

1. Assuming there is a code change in this contribution
2. Assuming there is a code change in this contribution
- [ ] Have you included unit test(s) to verify the change?
- [ ] Do all pre-existing unit tests pass as expected?
- [ ] Does the change break existing functionality, if so have you explained why doing so is necessary?
- [ ] Have you listed the possible side-effects or negative impacts of the code change.

1. Put `closes #XXXX` in your comment, where XXXX is the the issue that your PR fixes.
1. Provide any other information that pertinent to the PR you're making.
1. Click "Create pull request".
3. Put `closes #XXXX` in your comment, where XXXX is the the issue that your PR fixes.
4. Provide any other information that pertinent to the PR you're making.
5. Click "Create pull request".

Thanks again, we'll review your PR and and act accordingly.

0 comments on commit 5b85846

Please sign in to comment.