-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update depositors (proxies, transfers) synchronously #5553
Conversation
This should be in draft until #5550 is merged and rebased on that PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. There is a lot in this PR and I appreciate all the time it took to get this right.
There is a request for one new test and a question about the order of steps for work_create transaction.
Add a new transaction step. Replace behavior of queuing a job that runs a service with running a service that then queues a job closes #5457
so we can deprecate the old ones
156f2a5
to
5aa3758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reordering the work_create steps and getting in the test. This was quite a slog, but well done.
supercedes #5537
follow-up to #5529 and #5550
closes #5457
Deprecates ContentDepositorChangeEventJob which called ChangeContentDepositorService, replacing them with a service that does the work and then backgrounds the event logging.
Follow-on work will move file set updates to a new background job, since there might be a lot of file sets. Issue to be created, linked here.