Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: Add example greetd setup #80

Merged
merged 1 commit into from
Jan 29, 2025
Merged

data: Add example greetd setup #80

merged 1 commit into from
Jan 29, 2025

Conversation

agx
Copy link
Collaborator

@agx agx commented Jan 26, 2025

As we need to run phoc and an OSK it's good to have a working example.

This was taken from Debian and originally authored by

Arnaud Ferraris aferraris@debian.org

and is close to what Phosh uses for session startup.

It's not installed anywhere atm,

@samcday
Copy link
Owner

samcday commented Jan 26, 2025

Thanks for this. There's two reasons I've been dragging my heels on this:

  • I was originally planning to handle everything from the phrog binary. e.g earlier builds were spawning a phoc subprocess and using that if the required wl globals were missing, but I've since reverted that:
  • I want to get Run with gnome-session #70 sorted out before the next release so that power button is properly handled.

Once 🐸 runs under/with gnome-session, that would change things here quite a bit, right? For example, wouldn't it be expected that the OSK is spawned/managed by gnome-session in that case?

@agx
Copy link
Collaborator Author

agx commented Jan 26, 2025

I want to get #70 sorted out before the next release so that power button is properly handled.

That would likely still use a wrapper, just one that is closer to what phosh uses. Maybe we can even elevate phosh's session setup at one point and just pass a different session config.

data/phrog.toml Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this file should be dropped entirely:

  • Fedora uses vt = 2
  • Fedora + Alpine use greetd as user instead of Debian's _greetd
  • Alpine has no systemd

If I had a Makefile or Meson project in place then we could template this but for now I think it's just better for each distro to carry their own greetd config, WDYT?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was kind of thinking the same. Just mentioning a example in the README would be fine I think. Because anyways, in postmarketOS we have to override it. and its different in Arch, fedora and debian.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe mark it more clearly as example?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

As we need to run phoc and an OSK it's good to have a working
example.

This was taken from Debian and originally authored by

Arnaud Ferraris <aferraris@debian.org>

and is close to what Phosh uses for session startup.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
@agx
Copy link
Collaborator Author

agx commented Jan 28, 2025

v2

  • Rename folder to example-config
  • Comment on the greetd user
  • Drop phoc.ini, usually not needed
  • Mention example config in README

@samcday
Copy link
Owner

samcday commented Jan 29, 2025

Looks good, thanks for doing this. I'll merge now and work on massaging it into the Alpine packaging imminently.

@samcday samcday merged commit 5e91f34 into samcday:main Jan 29, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants