-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data: Add example greetd setup #80
Conversation
Thanks for this. There's two reasons I've been dragging my heels on this:
Once 🐸 runs under/with gnome-session, that would change things here quite a bit, right? For example, wouldn't it be expected that the OSK is spawned/managed by gnome-session in that case? |
That would likely still use a wrapper, just one that is closer to what phosh uses. Maybe we can even elevate phosh's session setup at one point and just pass a different session config. |
data/phrog.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe this file should be dropped entirely:
- Fedora uses
vt = 2
- Fedora + Alpine use
greetd
as user instead of Debian's_greetd
- Alpine has no systemd
If I had a Makefile or Meson project in place then we could template this but for now I think it's just better for each distro to carry their own greetd config, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was kind of thinking the same. Just mentioning a example in the README would be fine I think. Because anyways, in postmarketOS we have to override it. and its different in Arch, fedora and debian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe mark it more clearly as example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
As we need to run phoc and an OSK it's good to have a working example. This was taken from Debian and originally authored by Arnaud Ferraris <aferraris@debian.org> and is close to what Phosh uses for session startup. Signed-off-by: Guido Günther <agx@sigxcpu.org>
v2
|
Looks good, thanks for doing this. I'll merge now and work on massaging it into the Alpine packaging imminently. |
As we need to run phoc and an OSK it's good to have a working example.
This was taken from Debian and originally authored by
Arnaud Ferraris aferraris@debian.org
and is close to what Phosh uses for session startup.
It's not installed anywhere atm,