-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian packaging #104
Debian packaging #104
Conversation
I wonder if it wouldn't be more suitable to require network access and fetch things via Cargo? Otherwise it is very easy to get entangled in package transitions in Debian (or needing to patch around older versions, as you can see from the patches). (This can of course be switched later on later on as well) In e.g. xdg-desktop-portal-phosh we do the same: use Cargo + net access in CI and use packaged crates when uploading to Debian |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Perfect, this is much easier, thanks! Although now the problem is, it seems that a lot of the transitive deps I need are tied up in the various If I do a
Any suggestions here? I suspect you'll see this question and answer long before I figure this out myself 😅 |
For now I'm just cargo-culting all of Phosh's build-deps. I guess keeping this list in sync won't be too onerous. Would still love to know if there's a better way to do this though :) |
I wouldn't know of a better way. It's usually a matter of listing all the non-rust deps so the crates can be built. so if you build-depend on |
This comment has been minimized.
This comment has been minimized.
Thanks Arnaud! Signed-off-by: Sam Day <me@samcday.com>
This is the version currently packaged in Debian-trixie and Fedora. Signed-off-by: Sam Day <me@samcday.com>
Not sure what I was really trying to achieve here. There is (hopefully) zero people intending to run a full Phosh session on their device who can't spare any room for Bash. Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Debian was patching this out because it presumably breaks the build, though I'm not really sure why? Makes me wonder if I'm not linting/clippy-ing as hard as I could/should be... 🤔 Signed-off-by: Sam Day <me@samcday.com>
A couple more cases where we're pulling stuff from places in ::traits, but this isn't public in the versions of gtk/libhandy that Debian packages. Weird. Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Needed by the first-run test Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
5e0088d
to
d77cd57
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hmph, well... Building the What I have so far builds cleanly in a pristine I'm going to just give up on the GHA workflow for now and open a follow-up issue to track that. If it's getting built regularly in phosh-debs maybe I don't care about building it here anyway 🤔 |
Drop all the librust deps, and use the build deps from phosh instead. Signed-off-by: Sam Day <me@samcday.com>
Builds debs against the Phosh nightly repo Signed-off-by: Sam Day <me@samcday.com>
closes #67
This pulls in the DebianOnMobile packaging, and also absorbs the latest round of patches Arnaud had to apply to clean up my mess 😅