ui improvements

[oliursahin]

What did you ship?

Fixes:

• #XXX (GitHub issue number)
• MAR-XXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Checklist:

• I have self-reviewed the code (A decent size PR without self-review might be rejected)
• I pinky swear that my codes gonna work as I have testing every possible scenario.
• I ignored Coderabbit suggestion because it does not make any sense.
• I took Coderabbit suggestion under consideration as some of it makes sense.
• I have commented my code, particularly in hard-to-understand areas.

OR:

• shut up and let me cook.

---

Important

UI improvements across components, focusing on layout, styling, and interactivity enhancements.

• Layout and Structure:
  • inbox/page.tsx: Adjusted section and div heights for better layout.
  • layout.tsx: Wrapped main content in SidebarInset for improved sidebar integration.
  • grid-wrapper.tsx: Added max height and overflow auto to child divs.
• Styling:
  • assistant-modal.tsx: Increased z-index for modal elements.
  • list-items.tsx: Updated hover and text styles for list items.
  • input-box.tsx: Adjusted focus styles and placeholder text.
• Components:
  • app-sidebar.tsx: Removed redundant SidebarGroupLabel and adjusted menu item styles.
  • list.tsx: Removed Separator and adjusted padding for sections.

^{This description was created by for e9f8f32. It will automatically update as commits are pushed.}

[github-actions]

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

• feat: A new feature
• fix: A bug fix
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code
• refactor: A code change that neither fixes a bug nor adds a feature
• perf: A code change that improves performance
• test: Adding missing or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit

Format: type: description

Error details:

No release type found in pull request title "ui improvements". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - ui
 - refac
 - perf
 - test
 - build
 - ci
 - chore
 - revert

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 3a86efa in 49 seconds

More details

• Looked at 202 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 9 drafted comments based on config settings.

1. apps/web/src/app/(routes)/inbox/page.tsx:8

• Draft comment:
  Styling updates look good; the use of calc for height and overflow-auto ensures improved scroll behavior.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

2. apps/web/src/app/(routes)/today/page.tsx:9

• Draft comment:
  Removed 'h-full' from section; styling is now consistent with the new layout.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

3. apps/web/src/components/blocks/list/list-items.tsx:37

• Draft comment:
  Using an inline style for width ('18px') works but consider creating a constant or Tailwind utility class if reused to maintain consistency.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

4. apps/web/src/components/input/input-box.tsx:60

• Draft comment:
  The onBlur handler checks if e.relatedTarget is not a BUTTON; ensure that all interactive elements triggering submit are covered.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is suggesting to ensure that all interactive elements triggering submit are covered, which is a form of asking the author to double-check their work. This violates the rule against asking the author to ensure behavior is intended or to double-check things.

5. apps/web/src/components/sidebar/app-sidebar.tsx:32

• Draft comment:
  Removal of extra SidebarGroupLabel in the content helps clarity; ensure that this change aligns with design intent.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

6. apps/web/src/components/wrappers/grid-wrapper.tsx:24

• Draft comment:
  Adding a border and shadow to child containers enhances UI clarity; this is a good improvement consistent with other changes.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

7. apps/web/src/components/blocks/list/list-items.tsx:17

• Draft comment:
  Consider memoizing the reversed items (sortedItems) to avoid re-computation on every render if the items array grows large.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. apps/web/src/components/input/input-box.tsx:60

• Draft comment:
  The onBlur handler checks if the related target's tag is not 'BUTTON' to determine focus loss. This may be brittle if the submit element changes type. Consider a more robust focus management strategy.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

9. apps/web/src/components/blocks/list/list-items.tsx:37

• Draft comment:
  Inline style for fixed width ('18px') is used for the checkbox container. Consider extracting this value into a CSS class or constant to improve consistency and reuse.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

Workflow ID: wflow_OyTugWAyN9dVQFkd

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on e9f8f32 in 52 seconds

More details

• Looked at 63 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. apps/web/src/app/(routes)/layout.tsx:14

• Draft comment:
  Good use of SidebarInset wrapper to contain main layout. Confirm that SidebarInset’s styles meet layout needs.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

2. apps/web/src/components/assistant-ui/assistant-modal.tsx:14

• Draft comment:
  Double-check the high z-index (z-[9999]) on both Anchor and Content; ensure it won’t conflict with other UI elements.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

3. apps/web/src/app/(routes)/layout.tsx:14

• Draft comment:
  Using SidebarInset to wrap the main element helps with layout separation. Verify that its added styling doesn’t conflict with the container and main element classes.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. apps/web/src/components/assistant-ui/assistant-modal.tsx:14

• Draft comment:
  The increased z-index (z-[9999]) on both the Anchor and Content ensures the modal is on top. Confirm this high value doesn’t unintentionally overlay other UI elements. Consider extracting this value as a constant if it’s reused.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

Workflow ID: wflow_1loYXwGuYfQ6oV8E

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.