-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package icons as subpackages #479
Conversation
... so they get uninstalled properly (esp. when downgrading PM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From issue #472 comment-2514204204:
That should shift the burden to the package management solver and thereby solve (heh) our problems with build/install/SDK/release versions.
Cool, this PR proves (again) that "we can solve any problem by introducing an extra level of indirection"™.
But, as I have understood again that just also building with the SailfishOS-SDK for 4.6.0 in the ci_on_git-tags
workflow completely resolves this issue (AFAIU), and exactly that already happens at SailfishOS:Chum (i.e. the SailfishOS-OBS), I think this is over-engineered.
I.e. I like it technically (but that is principally "because we can"™ do cool things by restructuring the packaging via reworking a spec file), but it introduces additional complexity which makes maintenance harder (especially if other people should continue maintaining Patchmanager, as it already happened twice).
Hence currently I do not think this is needed. But maybe I have not understood how this structural change might be helpful in the future.
I.e. if this PR solely resolves the minor issue of the ci_on_git-tags
workflow currently not generating RPM packages suitable for SailfishOS ≥ 4.6.0, I strongly prefer to resolve this issue with a minor adaptation of the ci_on_git-tags
workflow configuration file (I will do that soon™).
Done per PR "[ci-on-tags.yml] Also build with SDK for 4.6.0" #485. |
Closing as another solution was implemented. |
* [ci-on-tags.yml] Also build with SDK for 4.6.0 See #479 (review) * [.github/workflows/ci-on-tags.yml] Align comment to recent changes * [.github/workflows/ci-on-tags.yml] Improve comment
Supporting two different filesystem locations depending on Sailfish OS version
while keeping the number of build environments to a minimum is problematic.
Instead of deciding where to install and what to package at build time, package and ship
both variants and let the package manager decide which is the right one.
See also: #472 (comment)
Things to test:
meegotouch
path and installs them at thesilica
location after/during an update from a lower version to SFOS 4.6SFOS GUI upgrades usually remove Patchmanager anyway AFAIK, so this last test may not be that important.