This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Use headless Chrome instead of PhantomJS to run tests 🤖 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a couple of options going forward: - Always ship with the default PhantomJS support but use Chrome if it is available; - Completely ditch PhantomJS, and make Chrome another global dependency of Sagui. However, it is currently only available in the Canary release. More info https://www.chromestatus.com/features/5678767817097216
|
We should also use the official support karma-runner/karma-chrome-launcher#111 once it is merged. |
|
How does this relate to the PR for switching to Electron? Should we reject that one? Seems like barebones Chromium is the way to go, clearly closer to metal than Electron. |
|
I think it is time for us to push this! https://developers.google.com/web/updates/2017/06/headless-karma-mocha-chai Headless support is already in Chrome stable! |
|
@npejo is preparing a new PR with a final solution. Rejecting this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple of options going forward:
However, it is currently only available in the Canary release.
More info https://www.chromestatus.com/features/5678767817097216