Various small improvements to imports #39276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly to try to reduce a few circular imports that happen when you don't import `sage.all`. A few of these changes are purely cosmetic.
tobiasdiez
force-pushed
the
import-fixes
branch
from
b6662f6 to
3050d63
Compare
|
Documentation preview for this PR (built with commit 3050d63; changes) is ready! 🎉 |
user202729
reviewed
Jan 5, 2025
| @@ -182,7 +181,7 @@ cdef Rational_sub_(Rational self, Rational other): | |||
|
|
|||
| return x | |||
|
|
|||
| cdef Parent the_rational_ring = sage.rings.rational_field.Q | |||
| cdef Parent the_rational_ring = Q | |||
There was a problem hiding this comment.
Not strictly related but maybe we can change to use QQ instead
There was a problem hiding this comment.
and may be use from sage.rings.rational_field import Q as the_rational_ring ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to try to reduce a few circular imports that happen when you don't import
sage.all. A few of these changes are purely cosmetic.📝 Checklist
⌛ Dependencies