Unpoison http_proxy for optional pkgs
#39226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit e887ab3; changes) is ready! 🎉 |
|
Since this is a policy change, I think we should at least inform sage-devel of the change. |
|
I concur. Please post the sage-devel discussion link here too. |
|
kwankyu
reviewed
Jan 16, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 19, 2025
This allows optional packages to download dependencies during installation. For details on the reasoning behind this change see [passagemath/issues/ 613](passagemath/passagemath#613). Post on `sage-devel`: https://groups.google.com/g/Sage- Devel/c/ZZIvoEHm5hg. URL: sagemath#39226 Reported by: gmou3 Reviewer(s): gmou3, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 20, 2025
This allows optional packages to download dependencies during installation. For details on the reasoning behind this change see [passagemath/issues/ 613](passagemath/passagemath#613). Post on `sage-devel`: https://groups.google.com/g/Sage- Devel/c/ZZIvoEHm5hg. URL: sagemath#39226 Reported by: gmou3 Reviewer(s): gmou3, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows optional packages to download dependencies during installation.
For details on the reasoning behind this change see passagemath/issues/613.
Post on
sage-devel: https://groups.google.com/g/Sage-Devel/c/ZZIvoEHm5hg.