add parameter forbidden_vertices to some connectivity methods
#39151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2b8f836; changes) is ready! 🎉 |
fchapoton
reviewed
Jan 10, 2025
|
codecov is now happy. |
|
Thank you ! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
…vity methods
I frequently have to do a depth/breadth-first search in a graph in which
some vertices are forbidden. Instead of removing the vertices from the
graph, we can simply ensure that the search will not visit these
vertices. Actually, the extra cost to do so is very small.
We add such extra functionality to depth/breadth-first search methods
for both directed and undirected graphs, and to connectivity methods in
undirected graphs. It remains to do the same for directed graphs, but in
a follow-up PR to ease the review.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39151
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
…vity methods
I frequently have to do a depth/breadth-first search in a graph in which
some vertices are forbidden. Instead of removing the vertices from the
graph, we can simply ensure that the search will not visit these
vertices. Actually, the extra cost to do so is very small.
We add such extra functionality to depth/breadth-first search methods
for both directed and undirected graphs, and to connectivity methods in
undirected graphs. It remains to do the same for directed graphs, but in
a follow-up PR to ease the review.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39151
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently have to do a depth/breadth-first search in a graph in which some vertices are forbidden. Instead of removing the vertices from the graph, we can simply ensure that the search will not visit these vertices. Actually, the extra cost to do so is very small.
We add such extra functionality to depth/breadth-first search methods for both directed and undirected graphs, and to connectivity methods in undirected graphs. It remains to do the same for directed graphs, but in a follow-up PR to ease the review.
📝 Checklist
⌛ Dependencies