-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix index out of range exception (#35031) #35156
Conversation
Reported by: seblabbe
Codecov ReportBase: 88.57% // Head: 88.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35156 +/- ##
===========================================
+ Coverage 88.57% 88.59% +0.01%
===========================================
Files 2140 2140
Lines 397273 397276 +3
===========================================
+ Hits 351891 351963 +72
+ Misses 45382 45313 -69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for the bug fix. You must add a doctest that shows that the error is indeed corrected. Ideally this would go inside a TESTS block such as this example taken from
See https://doc.sagemath.org/html/en/developer/coding_basics.html for the formatting of docstrings. |
Your example already "works" fine on sage 9.5 (in the sense that it does return |
Do you mean to use |
I made a mistake but then force pushed correct version |
Looks better now :) |
Just waiting for the CI before giving a positive review. |
Documentation preview for this PR is ready! 🎉 |
I see that the Build & Test is failing, but the error:
is not related to this ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
📚 Description
We return False if there is no n-th path
Closes #35031
📝 Checklist