Modernize to latest rustc #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,4 +40,4 @@ version = "*" | |||
| optional = true | |||
|
|
|||
| [dev-dependencies.deuterium_plugin] | |||
| version = "*" | |||
| path = "deuterium-plugin" | |||
There was a problem hiding this comment.
Please revert this because path deps can't be uploaded to the crates.io
|
@SkylerLipthay awesome work. Really awesome! Deuterium was published as v0.4.0. Please revert the path change in deuterium-plugin section and I merge this. |
Previous to this fix: if `delete` runs before `select` or `update`, `select` or `update` will fail.
|
Forced a push to remove the offending commit regarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chore work was a bit more involved than that of
deuterium-orm/deuterium. Package should build and all tests should pass as soon as the newest changes todeuterium-orm/deuteriumare published to crates.io (I was developing this PR with a locally modifiedCargo.toml).enum_primitivecrate. Hopefully a native solution comes around.syntax::print::pprust::ty_to_stringto replacesyntax::ext::quote::rt::ToSource. I'm not quite sure ifpprustis a one-to-one replacement, but it seems to work. Compiler plugins are always bound to break, anyway.