Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roborock S8 Pro Ultra #1891

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

spangenberg
Copy link
Contributor

Fixes #1864

@spangenberg spangenberg force-pushed the add-roborock-s8-pro-ultra branch from 62ae378 to 1694777 Compare January 23, 2024 09:36
@spangenberg
Copy link
Contributor Author

CI / Perform linting checks are unrelatedly failing and are also currently happening on master branch.

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

miio/devtools/pcapparser.py:54:13: B036 Don't except `BaseException` unless you plan to re-raise it.
miio/integrations/lumi/gateway/alarm.py:97:13: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
miio/integrations/lumi/gateway/devices/subdevice.py:334:13: B038 editing a loop's mutable iterable often leads to unexpected results/bugs```

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4354615) 81.41% compared to head (bfe8065) 81.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1891   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         193      193           
  Lines       18564    18565    +1     
  Branches     4024     4024           
=======================================
+ Hits        15113    15114    +1     
  Misses       3170     3170           
  Partials      281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rytilahti rytilahti merged commit 56c6d3f into rytilahti:master Feb 16, 2024
22 of 24 checks passed
@spangenberg spangenberg deleted the add-roborock-s8-pro-ultra branch February 28, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported device Roborock S8 Pro Ultra
3 participants