Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #8

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Update dependencies #8

merged 1 commit into from
Feb 14, 2024

Conversation

jaseb
Copy link
Contributor

@jaseb jaseb commented Feb 13, 2024

Update the README.md to mention Wasmtime 17.0, update to newer dependencies in Cargo.toml, and update Cargo.lock.

Amend runtime.rs to use wasmtime::component::ResourceTable as per changes in Wasmtime. See 7655

Unsure on the version of WASI-Virt required - this is the commit with 0.2.0 updates.

Copy link
Owner

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! Overall looks good. I just have one comment about some lingering comments that we probably want to remove.

Cargo.toml Outdated
wit-parser = "0.14.0"
wasm-compose = "0.5.5"

# wasi-virt = { git = "/~https://github.com/bytecodealliance/WASI-Virt", rev = "6801514735cb78b385221e225c554bc043038c2f" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep these comments around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, fixed.

@jaseb jaseb force-pushed the update_dependencies branch from f21fa8f to 35b1125 Compare February 13, 2024 23:31
@rylev
Copy link
Owner

rylev commented Feb 13, 2024

Seems that you'll need to run cargo fmt for CI to pass.

@jaseb jaseb force-pushed the update_dependencies branch from 35b1125 to 289d179 Compare February 14, 2024 00:00
@jaseb
Copy link
Contributor Author

jaseb commented Feb 14, 2024

Seems that you'll need to run cargo fmt for CI to pass.

Just noticed that, sorted.

@jaseb jaseb force-pushed the update_dependencies branch from 289d179 to 7a87edd Compare February 14, 2024 12:05
@rylev rylev merged commit 12ccf48 into rylev:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants