Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to FloatCore #41

Merged
merged 15 commits into from
Mar 1, 2018
Merged

Various improvements to FloatCore #41

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c848562
Use forwarding macros to implement Float and Real
cuviper Feb 27, 2018
ac50326
Forward FloatCore to inherent methods when possible
cuviper Feb 27, 2018
7d6575d
Add NumCast to FloatCore, matching Float
cuviper Feb 27, 2018
99c6cc1
Add more constants to FloatCore
cuviper Feb 28, 2018
f365a42
Add rounding methods to FloatCore
cuviper Feb 28, 2018
83d498d
Add integer_decode to FloatCore
cuviper Feb 28, 2018
6fa29be
Use macros for more float constants
cuviper Feb 28, 2018
8d16921
allow unused macros
cuviper Feb 28, 2018
964a7e5
Reinstate NAN-sign fixes in FloatCore
cuviper Feb 28, 2018
36c7e32
Fix FloatCore::powi with i32::MIN exponent
cuviper Feb 28, 2018
ac6eca4
Use more FloatCore in src/sign.rs
cuviper Feb 28, 2018
ec3cd50
Weaken the std f32::to_degrees/to_radians tests
cuviper Feb 28, 2018
aa9ceba
Add doctests to FloatCore
cuviper Feb 28, 2018
080f6f2
Comment the i32::MIN case for FloatCore::powi
cuviper Feb 28, 2018
04a3f2a
Comment the Rust version for NAN.is_sign_* behavior
cuviper Feb 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/float.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1493,8 +1493,8 @@ mod tests {
assert!((FloatCore::to_radians(deg) - rad).abs() < 1e-6);

let (deg, rad) = (deg as f32, rad as f32);
assert!((FloatCore::to_degrees(rad) - deg).abs() < 1e-6);
assert!((FloatCore::to_radians(deg) - rad).abs() < 1e-6);
assert!((FloatCore::to_degrees(rad) - deg).abs() < 1e-5);
assert!((FloatCore::to_radians(deg) - rad).abs() < 1e-5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I made it forward to std's f32::to_degrees, it started failing on nightly. I suspect rust-lang/rust#47919, which tried to be more accurate, actually made things less accurate for these inputs, but I haven't investigated yet. I will probably file an upstream bug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rust#48617

}
}

Expand All @@ -1508,8 +1508,8 @@ mod tests {
assert!((Float::to_radians(deg) - rad).abs() < 1e-6);

let (deg, rad) = (deg as f32, rad as f32);
assert!((Float::to_degrees(rad) - deg).abs() < 1e-6);
assert!((Float::to_radians(deg) - rad).abs() < 1e-6);
assert!((Float::to_degrees(rad) - deg).abs() < 1e-5);
assert!((Float::to_radians(deg) - rad).abs() < 1e-5);
}
}
}