Run doc tests for binaries on CI #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out a simple `cargo test` doesn't run doctests for binaries. It does run them for libraries though. The solution is to separate the test command into two `cargo test --all-targets` (which, unintuitively, doesn't invoke doc tests rust-lang/cargo#6669), and then run `cargo test --doc`
Veetaha
force-pushed
the
feat/doc-tests
branch
from
808230b to
c09dd45
Compare
xFrednet
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a simple
cargo testdoesn't run doctests for binaries. It does run them for libraries though.The solution is to separate the test command into two
cargo test --all-targets(which, unintuitively, doesn't invoke doc tests rust-lang/cargo#6669), and then runcargo test --doc.This doesn't solve #303 though.