-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more GitHub Actions enablement #3982
Conversation
001da7c
to
4b12a6a
Compare
8499269
to
cbe74a4
Compare
cbe74a4
to
02428c7
Compare
I also went ahead and added a few cargo aliases as part of this to simplify the command args for running tests with the new directory/crate structure, and updated the GHA workflows to leverage those aliases. For example |
@calebcartwright Thank you so much for setting GitHub Action in this repository! I'm all for migrating to GitHub Action. We are not worried about being locked-in to GitHub (as long as the rust itself is hosted on GitHub we must stay as well 🤷 ) and Travis is... has been slow and unstable, to say the least. Having said that, I'm still skeptical about the stability of GitHub Action. In particular, I don't know enough about whether Rust's support is sufficient. As such, I will keep using Travis and AppVeyor along with GitHub Action for a while. |
Yup that makes sense. GHA has been running well for Windows world for a while now for us, will be interesting to see how the Linux and Mac jobs hold up on GHA as well |
backported in #4436 |
Follow up to #3969 that enables GHA for Linux, Mac, and the Integration test jobs that are currently executed on Travis. I decided to go ahead and work on this since some of the other issues I was eyeing are blocked 😄
Similar to my experience enabling GHA for Windows in #3969, I found a few things took a little longer to set up due to the immaturity of the platform/features that haven't yet been released. However, overall it still seems really promising with several opportunities for continued improvement.