Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more GitHub Actions enablement #3982

Merged
merged 4 commits into from
Apr 21, 2020

Conversation

calebcartwright
Copy link
Member

@calebcartwright calebcartwright commented Dec 25, 2019

Follow up to #3969 that enables GHA for Linux, Mac, and the Integration test jobs that are currently executed on Travis. I decided to go ahead and work on this since some of the other issues I was eyeing are blocked 😄

Similar to my experience enabling GHA for Windows in #3969, I found a few things took a little longer to set up due to the immaturity of the platform/features that haven't yet been released. However, overall it still seems really promising with several opportunities for continued improvement.

@calebcartwright calebcartwright force-pushed the gh-actions2 branch 2 times, most recently from 001da7c to 4b12a6a Compare December 26, 2019 02:24
@calebcartwright calebcartwright force-pushed the gh-actions2 branch 4 times, most recently from 8499269 to cbe74a4 Compare January 8, 2020 03:26
@calebcartwright
Copy link
Member Author

calebcartwright commented Jan 8, 2020

I also went ahead and added a few cargo aliases as part of this to simplify the command args for running tests with the new directory/crate structure, and updated the GHA workflows to leverage those aliases.

For example cargo test-all (also aliased as cargo t) is now an alias that will run cargo test --manifest-path rustfmt-core/Cargo.toml (plus whatever other args/options provided to cargo test/libtest).

@topecongiro
Copy link
Contributor

@calebcartwright Thank you so much for setting GitHub Action in this repository!

I'm all for migrating to GitHub Action. We are not worried about being locked-in to GitHub (as long as the rust itself is hosted on GitHub we must stay as well 🤷 ) and Travis is... has been slow and unstable, to say the least.

Having said that, I'm still skeptical about the stability of GitHub Action. In particular, I don't know enough about whether Rust's support is sufficient. As such, I will keep using Travis and AppVeyor along with GitHub Action for a while.

@topecongiro topecongiro merged commit 82caa55 into rust-lang:master Apr 21, 2020
@calebcartwright
Copy link
Member Author

As such, I will keep using Travis and AppVeyor along with GitHub Action for a while.

Yup that makes sense. GHA has been running well for Windows world for a while now for us, will be interesting to see how the Linux and Mac jobs hold up on GHA as well

@calebcartwright calebcartwright deleted the gh-actions2 branch April 21, 2020 03:05
@karyon
Copy link
Contributor

karyon commented Oct 25, 2021

backported in #4436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants