-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump rustc-ap crates #3870
bump rustc-ap crates #3870
Conversation
@@ -429,8 +428,11 @@ source = "registry+/~https://github.com/rust-lang/crates.io-index" | |||
|
|||
[[package]] | |||
name = "memoffset" | |||
version = "0.2.1" | |||
version = "0.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main point of the update: old memoffset
is broken in many ways, and I am trying to remove it from the rustc dependency chain.
Well, CI is getting the same build failures as I did locally for crossbeam-channel. The odd part is that it seems to ignore the lockfile:
|
Believe rust-lang/rust#65424 is probably still relevant on the crossbeam-utils front |
Ah yes that would explain it. I also learned rustc-ap updates need to be coordinated with Racer -- does that mean submitting a PR there as well, or more than that? I updated these crates to version 610 instead of the latest (616) to keep the delta smaller. Not sure what the usual policy is here. |
I think so, but @topecongiro would be able to answer definitively |
@RalfJung Thank you for the PR!
Yes, updating the
Given that updating the |
I bumped these in racer as well: racer-rust/racer#1078 Looks like a rustfmt release is needed to make RLS depend on the new version? What is the usual process here, do you just do that fairly regularly and we wait for the next cycle? |
Yes.
We don't do this regularly but rather from the urgent need, e.g. supporting a new syntax or fixing the broken tool-state. I will make the next release within a day. |
@RalfJung As a part of the next release, I will update rustc-ap-* crates to the latest version (617 or 618, depending on the timing). |
There's no urgency to this, I am just trying to get |
For some reason I also had to do
as otherwise things wouldn't build. Even
rustfmt
master does not build for me. See crossbeam-rs/crossbeam#435.