Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rustc-ap crates #3870

Merged
merged 1 commit into from
Oct 19, 2019
Merged

bump rustc-ap crates #3870

merged 1 commit into from
Oct 19, 2019

Conversation

RalfJung
Copy link
Member

For some reason I also had to do

cargo update -p crossbeam-utils --precise 0.6.5

as otherwise things wouldn't build. Even rustfmt master does not build for me. See crossbeam-rs/crossbeam#435.

@@ -429,8 +428,11 @@ source = "registry+/~https://github.com/rust-lang/crates.io-index"

[[package]]
name = "memoffset"
version = "0.2.1"
version = "0.5.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main point of the update: old memoffset is broken in many ways, and I am trying to remove it from the rustc dependency chain.

@RalfJung
Copy link
Member Author

Well, CI is getting the same build failures as I did locally for crossbeam-channel. The odd part is that it seems to ignore the lockfile:

   Compiling crossbeam-utils v0.6.6

@calebcartwright
Copy link
Member

Believe rust-lang/rust#65424 is probably still relevant on the crossbeam-utils front

@RalfJung
Copy link
Member Author

Ah yes that would explain it.

I also learned rustc-ap updates need to be coordinated with Racer -- does that mean submitting a PR there as well, or more than that?

I updated these crates to version 610 instead of the latest (616) to keep the delta smaller. Not sure what the usual policy is here.

@calebcartwright
Copy link
Member

I also learned rustc-ap updates need to be coordinated with Racer -- does that mean submitting a PR there as well, or more than that?

I think so, but @topecongiro would be able to answer definitively
/~https://github.com/rust-lang/rustfmt/blob/master/Processes.md#5-create-a-pr-to-rust-langrust-to-update-the-rustfmt-submodule

@topecongiro
Copy link
Contributor

@RalfJung Thank you for the PR!

I also learned rustc-ap updates need to be coordinated with Racer -- does that mean submitting a PR there as well, or more than that?

Yes, updating the rustc-ap-* crates needs to be coordinated among repositories that are registered as submodules in the rustc repo.

I updated these crates to version 610 instead of the latest (616) to keep the delta smaller. Not sure what the usual policy is here.

Given that updating the rustc-ap-* crates are somewhat daunting, I prefer to update to the latest version if possible.

@topecongiro topecongiro merged commit 0497a7d into rust-lang:master Oct 19, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Oct 19, 2019

I bumped these in racer as well: racer-rust/racer#1078

Looks like a rustfmt release is needed to make RLS depend on the new version? What is the usual process here, do you just do that fairly regularly and we wait for the next cycle?

@RalfJung RalfJung deleted the bump branch October 19, 2019 09:21
@topecongiro
Copy link
Contributor

Looks like a rustfmt release is needed to make RLS depend on the new version?

Yes.

What is the usual process here, do you just do that fairly regularly and we wait for the next cycle?

We don't do this regularly but rather from the urgent need, e.g. supporting a new syntax or fixing the broken tool-state. I will make the next release within a day.

@topecongiro
Copy link
Contributor

@RalfJung As a part of the next release, I will update rustc-ap-* crates to the latest version (617 or 618, depending on the timing).

@RalfJung
Copy link
Member Author

There's no urgency to this, I am just trying to get memoffset 0.2 out of the rustc dependency graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants