Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change what we check in CI profiling test #2030

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Change what we check in CI profiling test #2030

merged 2 commits into from
Jan 8, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 7, 2025

Fixes: #2028

@Kobzol Kobzol requested a review from Mark-Simulacrum January 7, 2025 10:15
lqd
lqd reviewed Jan 8, 2025
View reviewed changes
ci/check-profiling.sh Outdated Show resolved Hide resolved
@Kobzol @lqd
Fix typo
8e4d255 
Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
lqd
lqd approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know if you only wanted mark’s review, but this looks good to me as a smoke test.

@Kobzol Kobzol merged commit c6c361b into rust-lang:master Jan 8, 2025
11 checks passed
@Kobzol Kobzol deleted the jemalloc-profiler branch January 8, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failing due to jemalloc symbol changes
2 participants
@Kobzol @lqd