Do not suggest impl traits as type arguments #86338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
joelpalmer
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #87698) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @estebank |
estebank
approved these changes
Aug 3, 2021
|
|
||
| /// Returns `true` if `params` has `impl Trait`. | ||
| pub fn has_impl_trait(&'tcx self) -> bool { | ||
| self.params.iter().any(|param| { |
There was a problem hiding this comment.
I guess we could also add an fn is_impl_trait to param, but that's not necessary in this PR.
|
@bors r+ |
|
📌 Commit b84d08d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86162