-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for incorrect impl Foo<const N: ty> {}
syntax
#85346
Conversation
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
Error message looks good to me! @bors r+ |
📌 Commit 714f0086c1805c51e3937caa3312bfd8569ca587 has been approved by |
⌛ Testing commit 714f0086c1805c51e3937caa3312bfd8569ca587 with merge 42656b00254b737e66b0e4bcb7ebc12bde066049... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #86080) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
cc @estebank: this is waiting on a rebase. |
@bors r=varkor |
📌 Commit 332a327394286cb3d0186a34fc634a5bb110729a has been approved by |
⌛ Testing commit 332a327394286cb3d0186a34fc634a5bb110729a with merge e1fa3a00922b6beb11caed1133eaf12796d8159d... |
📌 Commit 46502de0bccc789be9d6862f5d4c78e667cdfd9a has been approved by |
This comment has been minimized.
This comment has been minimized.
46502de
to
505b09e
Compare
Forgot to @bors r=nagisa,varkor |
📌 Commit 505b09e has been approved by |
⌛ Testing commit 505b09e with merge 9fa96d7a643326093ee155a054874243fa007326... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c6eda7d): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Use the available Generics span field to avoid issues with `T: Fn()` bounds. This is necessary to land rust-lang#85346.
Fix #84946