Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #75421

Merged
merged 15 commits into from
Aug 11, 2020
Merged

Rollup of 7 pull requests #75421

merged 15 commits into from
Aug 11, 2020

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Aug 11, 2020

Successful merges:

Failed merges:

r? @ghost

petrochenkov and others added 15 commits August 11, 2020 00:08
`rustc::lint::builtin` -> `rustc_session::lint::builtin`
`range` is not an element, it is a variable.
Prefer pattern matching over indexing

Quite a bit nicer IMO.

r? @cuviper
…crum

Introduce `rustc_lexer::is_ident` and use it in couple of places

Implements the suggestion from rust-lang#74537 (comment).
…cstatic-morse

Update comment for function

`rustc::lint::builtin` -> `rustc_session::lint::builtin`
…fJung

Requested changes to [*mut T|*const T]::set_ptr_value

This is a follow-up to PR rust-lang#74774 (tracking issue rust-lang#75091), acting on some change requests made after approval:

- adds `#[must_use]` attribute
- changes type of `val` pointer argument from `()` to `u8`
- adjusts documentation mentioning pointer provenance
Fix range term in alloc vec doc

`range` is not an element, it is a variable.

r? @GuillaumeGomez
@tmandry
Copy link
Member Author

tmandry commented Aug 11, 2020

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented Aug 11, 2020

📌 Commit 5d9a0b0 has been approved by tmandry

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2020
@tmandry tmandry added the rollup A PR which is a rollup label Aug 11, 2020
@bors
Copy link
Contributor

bors commented Aug 11, 2020

⌛ Testing commit 5d9a0b0 with merge e5e33eb...

@bors
Copy link
Contributor

bors commented Aug 11, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: tmandry
Pushing e5e33eb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 11, 2020
@bors bors merged commit e5e33eb into rust-lang:master Aug 11, 2020
@bors bors mentioned this pull request Aug 11, 2020
@tmandry tmandry deleted the rollup-ctzmzn1 branch August 17, 2020 21:57
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants