Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #74019

Merged
merged 43 commits into from
Jul 4, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
291dce9
Fallback to xml.etree.ElementTree
tmiasko Jun 8, 2020
6b95f31
Add `format_args_capture` feature
davidhewitt Oct 12, 2019
8caf604
Improve messaging from PR feedback
davidhewitt Jun 27, 2020
a1217cb
Add `format_args_capture` to the unstable book
davidhewitt Jun 27, 2020
db539c6
Use raw_ref_op in A|Rc::as_ptr
CAD97 Jun 28, 2020
e4bdf47
Do not require ptr validity in rc::data_offset
CAD97 Jun 28, 2020
d8a9c61
Use impl for Weak::as_ptr that works for unsized T
CAD97 Jun 28, 2020
fc3dc72
Clarify safety comment for A|Rc::as_ptr
CAD97 Jun 30, 2020
0aecf3c
Fix invalid pointer deref in Weak::as_ptr
CAD97 Jun 30, 2020
aed88e1
Clarify when rc::data_offset is safe
CAD97 Jun 30, 2020
b4d0457
Use exhaustive match in const_prop.rs
wesleywiser Jun 24, 2020
1a03432
Amend wording of note
davidhewitt Jun 30, 2020
aac2f73
Improve comments from /~https://github.com/rust-lang/rust/pull/72617, a…
eduardosm Jul 1, 2020
10ebb2c
Update src/librustc_builtin_macros/format.rs
davidhewitt Jul 1, 2020
ac40d1e
Apply documentation review suggestions
CAD97 Jul 1, 2020
98789ac
Simplify Weak::as_ptr impl
CAD97 Jul 1, 2020
7498cad
Reclarify safety comments in Weak::as_ptr
CAD97 Jul 1, 2020
0f1adc8
Further improve comments in libstd/panicking.rs.
eduardosm Jul 2, 2020
1b5ac57
Note Weak.ptr never dangles sooner
CAD97 Jul 2, 2020
bdc1f40
Standardize bibliographic citations in rustc API docs
pierwill Jun 30, 2020
e3f599c
Add test for simplify-try misoptimization
wesleywiser Jun 22, 2020
9248d90
[mir-opt] Prevent mis-optimization when SimplifyArmIdentity runs
wesleywiser Jun 22, 2020
24bfdc9
Fix debuginfo so that it points to the correct local
wesleywiser Jun 21, 2020
e16d6a6
Fix missing return in `optimization_applies()`
wesleywiser Jun 21, 2020
df43dcd
Fix "getting started" link
e00E Jul 3, 2020
3ed320e
fix typo
lcnr Jul 3, 2020
3bb6dc7
Bump mingw-check CI image from Ubuntu 16.04 to 18.04.
eddyb Jul 3, 2020
93d662f
Ignore test with panic on wasm targets
davidhewitt Jul 3, 2020
20caf63
Edit docs for rustc_data_structures::graph::scc
pierwill Jun 30, 2020
d64a4b5
Create new E0768 error code for "no valid digits found for number" error
GuillaumeGomez Jul 3, 2020
6970c92
Update UI tests
GuillaumeGomez Jul 3, 2020
df8f551
Rollup merge of #73140 - tmiasko:element-tree, r=GuillaumeGomez
Manishearth Jul 4, 2020
4a8d9ea
Rollup merge of #73670 - davidhewitt:format-args-capture, r=varkor
Manishearth Jul 4, 2020
50dcefc
Rollup merge of #73693 - wesleywiser:const_prop_exhaustive_match, r=o…
Manishearth Jul 4, 2020
9a659c5
Rollup merge of #73845 - CAD97:weak-as-unsized-ptr, r=RalfJung
Manishearth Jul 4, 2020
6339abd
Rollup merge of #73861 - GuillaumeGomez:create-e0767, r=Dylan-DPC
Manishearth Jul 4, 2020
d46de10
Rollup merge of #73881 - pierwill:pierwill-citations, r=jonas-schievink
Manishearth Jul 4, 2020
9d0ca38
Rollup merge of #73925 - eduardosm:improve-pr72617-comments, r=RalfJung
Manishearth Jul 4, 2020
60cad20
Rollup merge of #73949 - wesleywiser:simplify_try_fixes, r=oli-obk
Manishearth Jul 4, 2020
70c4b2f
Rollup merge of #73984 - pierwill:pierwill-tarjan, r=jonas-schievink
Manishearth Jul 4, 2020
e4c505b
Rollup merge of #73985 - e00E:fix-getting-started-link, r=jonas-schie…
Manishearth Jul 4, 2020
e005c97
Rollup merge of #73997 - rust-lang:lcnr-patch-1, r=jonas-schievink
Manishearth Jul 4, 2020
d69a846
Rollup merge of #73999 - eddyb:svv-prereq, r=Mark-Simulacrum
Manishearth Jul 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix invalid pointer deref in Weak::as_ptr
  • Loading branch information
CAD97 committed Jun 30, 2020
commit 0aecf3c74b7fd09460f453e7e95ae8cb65a92440
2 changes: 1 addition & 1 deletion src/liballoc/rc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1711,7 +1711,7 @@ impl<T> Weak<T> {
// because dangling weaks are only created for sized T. wrapping_offset
// is used so that we can use the same code path for dangling weak refs.
unsafe {
let offset = data_offset(&raw const (*ptr).value);
let offset = data_offset(fake_ptr);
set_data_ptr(fake_ptr, (ptr as *mut u8).wrapping_offset(offset))
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/liballoc/sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ impl<T> Weak<T> {
// because dangling weaks are only created for sized T. wrapping_offset
// is used so that we can use the same code path for dangling weak refs.
unsafe {
let offset = data_offset(&raw const (*ptr).data);
let offset = data_offset(fake_ptr);
set_data_ptr(fake_ptr, (ptr as *mut u8).wrapping_offset(offset))
}
}
Expand Down