Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote references to constants instead of statics #67000

Merged
merged 23 commits into from
Jan 11, 2020
Merged

Promote references to constants instead of statics #67000

merged 23 commits into from
Jan 11, 2020

Conversation

spastorino
Copy link
Member

@spastorino spastorino commented Dec 3, 2019 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2019
oli-obk
oli-obk reviewed Dec 3, 2019
View reviewed changes
src/librustc/ty/walk.rs Outdated Show resolved Hide resolved
src/librustc_codegen_ssa/mir/constant.rs Outdated Show resolved Hide resolved
src/librustc_mir/transform/check_consts/qualifs.rs Outdated Show resolved Hide resolved
@spastorino spastorino force-pushed the remove-promoted-from-place branch 4 times, most recently from a68a206 to 59d32ad Compare December 4, 2019 20:14
@spastorino spastorino force-pushed the remove-promoted-from-place branch 8 times, most recently from 01ecd4a to 9eebc48 Compare December 7, 2019 12:18
@oli-obk oli-obk mentioned this pull request Dec 10, 2019
Merged
@spastorino spastorino force-pushed the remove-promoted-from-place branch from 9eebc48 to 1161a46 Compare December 10, 2019 15:06
oli-obk
oli-obk requested changes Dec 10, 2019
View reviewed changes
src/librustc/mir/mod.rs Show resolved Hide resolved
src/librustc_mir/interpret/intern.rs Show resolved Hide resolved
src/librustc_mir/transform/const_prop.rs Show resolved Hide resolved
src/librustc_mir/transform/promote_consts.rs Outdated Show resolved Hide resolved
src/librustc_mir/transform/promote_consts.rs Outdated Show resolved Hide resolved
@spastorino spastorino force-pushed the remove-promoted-from-place branch 2 times, most recently from 409de5b to 52d18bd Compare December 10, 2019 18:14
@spastorino spastorino changed the title Promote references to constants instead of static Promote references to constants instead of statics Dec 10, 2019
@spastorino spastorino force-pushed the remove-promoted-from-place branch from 52d18bd to 2ba78e2 Compare December 10, 2019 18:24
@rust-lang rust-lang deleted a comment from rust-highfive Dec 10, 2019
@spastorino spastorino force-pushed the remove-promoted-from-place branch 5 times, most recently from 041233c to 8b262d2 Compare December 11, 2019 04:32
@rust-lang rust-lang deleted a comment from rust-highfive Dec 11, 2019
@bors
Copy link
Contributor

bors commented Jan 11, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 1389494 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2020
@bors bors merged commit e51eccd into rust-lang:master Jan 11, 2020
This was referenced Jan 11, 2020
Merged
Merged
Closed
Closed
Merged
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Jan 11, 2020
@JohnTitor
Rustup to rust-lang/rust#67000
8a3a0ea
This was referenced Jan 14, 2020
Closed
Merged
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#68236 - JohnTitor:ice-tests, r=Centril
2039d7e 
Add some regression tests

Closes rust-lang#64848 (fixed by rust-lang#67631)
Closes rust-lang#65918 (ICE is hidden by rust-lang#67000, no longer ICE)
Closes rust-lang#66473 (fixed by rust-lang#68084)
Closes rust-lang#67550 (set mir-opt-level to 3)

r? @Centril
@jonas-schievink jonas-schievink mentioned this pull request Feb 8, 2020
Closed
@RalfJung RalfJung mentioned this pull request Feb 11, 2020
Closed
@bjorn3 bjorn3 mentioned this pull request Apr 2, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Feb 9, 2023
Closed
JohnTitor added a commit to JohnTitor/rustc-dev-guide that referenced this pull request Mar 3, 2023
@JohnTitor
Reflect the changes in rust-lang/rust#67000
195ad7f 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
JohnTitor added a commit to JohnTitor/rustc-dev-guide that referenced this pull request Mar 3, 2023
@JohnTitor
Reflect the changes in rust-lang/rust#67000
21617db 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
spastorino pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 6, 2023
@JohnTitor
Reflect the changes in rust-lang/rust#67000 (#1632)
c1d92ca 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@rustbot rustbot mentioned this pull request Mar 13, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#109083 - rustbot:docs-update, r=ehuss
f6f238f 
Update books

## rust-lang/nomicon

1 commits in 79b53665a7c61d171fb8c5ad0b73b371f9ee6ba7..1f3e4cd4fd88b5b5d45feb86a11b6d2f93e5a974
2023-03-12 21:51:29 UTC to 2023-03-12 21:51:29 UTC

- Change incorrect reference to "above" in ffi.md (rust-lang/nomicon#404)

## rust-lang/reference

4 commits in a9afb04b47a84a6753e4dc657348c324c876102c..24c87f6663aed55b05d2cc286878f28f21918825
2023-03-11 13:53:24 UTC to 2023-02-28 16:07:20 UTC

- Document movbe target feature (rust-lang/reference#1336)
- fix typo (rust-lang/reference#1339)
- fix: Typo/reference (rust-lang/reference#1338)
- Document `cmpxchg16b` target feature (rust-lang/reference#1331)

## rust-lang/rustc-dev-guide

13 commits in b06dab8..b1b6d69
2023-03-13 02:42:00 UTC to 2023-03-03 11:12:51 UTC

- Rename `config.toml.example` to `config.example.toml` (rust-lang/rustc-dev-guide#1641)
- fix typo `SubstRef` to `SubstsRef` (rust-lang/rustc-dev-guide#1642)
- tracing log along diff crates (rust-lang/rustc-dev-guide#1640)
- Fix Rust Analyzer settings location (rust-lang/rustc-dev-guide#1637)
- Reflect the changes in rust-lang#67000 (rust-lang/rustc-dev-guide#1632)
- improve capacity note (rust-lang/rustc-dev-guide#1634)
- Remove mention to lexer/parser refactoring (rust-lang/rustc-dev-guide#1629)
- Update date reference about infer context variables (rust-lang/rustc-dev-guide#1630)
- Update explnation about `Body.basic_blocks` (rust-lang/rustc-dev-guide#1631)
- Add detail to contributing guide (rust-lang/rustc-dev-guide#1628)
- Making the sentence more clear (rust-lang/rustc-dev-guide#1624)
- Fixed typing error (rust-lang/rustc-dev-guide#1623)
- update error code docs to reflect recent changes (rust-lang/rustc-dev-guide#1625)
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2024
@bors
Auto merge of rust-lang#123936 - Mark-Simulacrum:zst-no-alloc, r=<try>
f266dba 
Codegen ZSTs without an allocation

This makes sure that &[] is equivalent to unsafe code (from_raw_parts(dangling, 0)). No new stable guarantee is intended about whether or not we do this, this is just an optimization.

This regressed in rust-lang#67000 (no comments I can see about that regression in the PR, though it did change the test modified here). We had previously performed this optimization since rust-lang#63635.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2024
@bors
Auto merge of rust-lang#123936 - Mark-Simulacrum:zst-no-alloc, r=<try>
0d984e9 
Codegen ZSTs without an allocation

This makes sure that &[] is equivalent to unsafe code (from_raw_parts(dangling, 0)). No new stable guarantee is intended about whether or not we do this, this is just an optimization.

This regressed in rust-lang#67000 (no comments I can see about that regression in the PR, though it did change the test modified here). We had previously performed this optimization since rust-lang#63635.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@bors
Auto merge of rust-lang#123936 - Mark-Simulacrum:zst-no-alloc, r=oli-obk
38104f3 
Codegen ZSTs without an allocation

This makes sure that &[] is equivalent to unsafe code (from_raw_parts(dangling, 0)). No new stable guarantee is intended about whether or not we do this, this is just an optimization.

This regressed in rust-lang#67000 (no comments I can see about that regression in the PR, though it did change the test modified here). We had previously performed this optimization since rust-lang#63635.
@pnkfelix pnkfelix mentioned this pull request Apr 29, 2024
Merged
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Dec 30, 2024
@JohnTitor
Reflect the changes in rust-lang#67000 (rust-lang#1632)
c5a38aa 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
@JohnTitor
Reflect the changes in rust-lang#67000 (rust-lang#1632)
21d7ef9 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 3, 2025
@JohnTitor
Reflect the changes in rust-lang/rust#67000 (rust-lang#1632)
70e8b3e 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewjasper matthewjasper matthewjasper left review comments

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@spastorino @rust-highfive @bors @rust-timer @oli-obk @matthewjasper @jplatte @Centril @RalfJung