Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split libcore::mem into multiple files #61310

Merged
merged 2 commits into from
May 29, 2019
Merged

split libcore::mem into multiple files #61310

merged 2 commits into from
May 29, 2019

Conversation

RalfJung
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2019
Centril
Centril approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me with green travis.

@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still r=me, etc. etc. 😄

@RalfJung
Copy link
Member Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented May 29, 2019

📌 Commit d0b3774 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2019
@RalfJung
Copy link
Member Author

High bitrotting potential.

@bors p=1

Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
@Centril
Rollup merge of rust-lang#61310 - RalfJung:mem, r=Centril
e39b015 
split libcore::mem into multiple files

r? @Centril
@Centril Centril mentioned this pull request May 29, 2019
Closed
@Centril
Copy link
Contributor

Centril commented May 29, 2019

Rolled up into #61316.

oli-obk added a commit to oli-obk/rust that referenced this pull request May 29, 2019
@oli-obk
Rollup merge of rust-lang#61310 - RalfJung:mem, r=Centril
1896756 
split libcore::mem into multiple files

r? @Centril
@oli-obk oli-obk mentioned this pull request May 29, 2019
Merged
bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #61317 - oli-obk:rollup-tm5qivq, r=oli-obk
37d001e 
Rollup of 7 pull requests

Successful merges:

 - #60549 (do not print panic message on doctest failures)
 - #60885 (strip synstructure consts from compiler docs)
 - #61217 (Account for short-hand init structs when suggesting conversion)
 - #61261 (is_union returns ty to avoid computing it twice)
 - #61293 (Print const generics properly in rustdoc)
 - #61310 (split libcore::mem into multiple files)
 - #61313 (Simplify Set1::insert)

Failed merges:

r? @ghost
@bors bors merged commit d0b3774 into rust-lang:master May 29, 2019
@RalfJung RalfJung deleted the mem branch May 30, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rust-highfive @bors @Centril @kud1ing