-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused variable suggestions apply on all patterns. #57899
Conversation
1eb1f25
to
12cdaec
Compare
@bors r+ |
1 similar comment
@bors r+ |
@bors are you still there? |
@bors r=estebank |
📌 Commit 12cdaec has been approved by |
@estebank Bors just likes me more =P |
Rollup fairness, @bors p=1 |
Unused variable suggestions apply on all patterns. Fixes rust-lang#56685. This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm. r? @estebank cc @alexcrichton (since you filed the issue)
⌛ Testing commit 12cdaec with merge 22768ccab68d22ea475f136f1e127f56404ec297... |
Failed in rollup, #57930 (comment) @bors r- retry |
This comment has been minimized.
This comment has been minimized.
12cdaec
to
cd6e1ce
Compare
@bors r+ |
📌 Commit cd6e1ce has been approved by |
Unused variable suggestions apply on all patterns. Fixes rust-lang#56685. This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm. r? @estebank cc @alexcrichton (since you filed the issue)
⌛ Testing commit cd6e1ce with merge b9a301e3d36e874c739116af6e2e5550dbdb2787... |
Failed in rollup, #57938 (comment). @bors r- retry |
This comment has been minimized.
This comment has been minimized.
@estebank |
This commit extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
cd6e1ce
to
5f021e0
Compare
@bors r=estebank |
📌 Commit 5f021e0 has been approved by |
Unused variable suggestions apply on all patterns. Fixes #56685. This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm. r? @estebank cc @alexcrichton (since you filed the issue)
☀️ Test successful - checks-travis, status-appveyor |
☀️ Test successful - checks-travis, status-appveyor |
Fixes #56685.
This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
r? @estebank
cc @alexcrichton (since you filed the issue)