Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable suggestions apply on all patterns. #57899

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

davidtwco
Copy link
Member

Fixes #56685.

This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.

r? @estebank
cc @alexcrichton (since you filed the issue)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2019
src/test/ui/issues/issue-56685.rs Show resolved Hide resolved
src/librustc/middle/liveness.rs Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor

@bors r+

1 similar comment
@estebank
Copy link
Contributor

@bors r+

@estebank
Copy link
Contributor

@bors are you still there?

@Centril Centril closed this Jan 25, 2019
@Centril Centril reopened this Jan 25, 2019
@Centril
Copy link
Contributor

Centril commented Jan 25, 2019

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jan 25, 2019

📌 Commit 12cdaec has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019
@Centril
Copy link
Contributor

Centril commented Jan 25, 2019

@estebank Bors just likes me more =P

@Centril
Copy link
Contributor

Centril commented Jan 26, 2019

Rollup fairness, @bors p=1

Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
Unused variable suggestions apply on all patterns.

Fixes rust-lang#56685.

This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.

r? @estebank
cc @alexcrichton (since you filed the issue)
@bors
Copy link
Contributor

bors commented Jan 27, 2019

⌛ Testing commit 12cdaec with merge 22768ccab68d22ea475f136f1e127f56404ec297...

@Centril
Copy link
Contributor

Centril commented Jan 27, 2019

Failed in rollup, #57930 (comment)

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2019
@bors

This comment has been minimized.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 27, 2019

📌 Commit cd6e1ce has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
Unused variable suggestions apply on all patterns.

Fixes rust-lang#56685.

This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.

r? @estebank
cc @alexcrichton (since you filed the issue)
@bors
Copy link
Contributor

bors commented Jan 28, 2019

⌛ Testing commit cd6e1ce with merge b9a301e3d36e874c739116af6e2e5550dbdb2787...

@Centril
Copy link
Contributor

Centril commented Jan 28, 2019

Failed in rollup, #57938 (comment).

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2019
@rust-lang rust-lang deleted a comment from rust-highfive Jan 28, 2019
@estebank

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Jan 28, 2019

@estebank --bless your heart ;)

This commit extends existing suggestions to prefix unused variable
bindings in match arms with an underscore so that it applies to all
patterns in a match arm.
@davidtwco
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jan 28, 2019

📌 Commit 5f021e0 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2019
@bors
Copy link
Contributor

bors commented Jan 28, 2019

⌛ Testing commit 5f021e0 with merge a21bd75...

bors added a commit that referenced this pull request Jan 28, 2019
Unused variable suggestions apply on all patterns.

Fixes #56685.

This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.

r? @estebank
cc @alexcrichton (since you filed the issue)
@bors
Copy link
Contributor

bors commented Jan 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing a21bd75 to master...

@bors
Copy link
Contributor

bors commented Jan 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing a21bd75 to master...

@bors bors merged commit 5f021e0 into rust-lang:master Jan 28, 2019
@davidtwco davidtwco deleted the issue-56685 branch January 28, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion for unused variables can sometimes be incorrect
5 participants