-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration div mul extras #52813
Merged
Merged
Duration div mul extras #52813
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c24fb12
duration div mul extras
newpavlov 12d8f27
review update
newpavlov 3e07236
add MAX_NANOS_F64 constant
newpavlov 2c300fa
change negativity check
newpavlov 2cab0de
don't duplicate impls
newpavlov d48a649
1.29.0 -> 1.30.0
newpavlov 0673417
Move float ops to unstable inherent methods
newpavlov 36dff2a
Remove tests
newpavlov 206ca68
remove newline
newpavlov 07c15ea
more explicit impl
newpavlov c5cbea6
fix doctests
newpavlov 533c0f0
fix tests
newpavlov c11281f
fix tests
newpavlov 37972ae
add as_float_secs and from_float_secs methods, refactor float methods
newpavlov 8a0aa9f
remove trailing spaces
newpavlov 9e78cb2
move checks to from_float_secs
newpavlov 2aca697
add panics section to method docs
newpavlov fd7565b
Added tracking issue, fixed check, 1.30 -> 1.31
newpavlov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these assertions be moved into
float_from_secs
perhaps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, yes, you are right.