Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 16 pull requests #52735

Merged
merged 59 commits into from
Jul 26, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
38abca8
Point at internal span in format string
Jul 23, 2018
87f0c1f
Suggest to take and ignore args while closure args count mismatching
csmoe Jul 23, 2018
4230659
Point at incorrect named arg in format string
Jul 23, 2018
338d545
Don't match on region kinds when reporting NLL errors
matthewjasper Jul 22, 2018
6bcf877
Point only at invalid positional arguments
estebank Jul 23, 2018
c55a698
Only point at inside of string literals if they're actually string li…
estebank Jul 23, 2018
bde2be0
Add test for raw string
estebank Jul 23, 2018
22d0ab0
Pass multiple linker arguments rather than concatenate with commas; -…
alecmocatta Jul 23, 2018
5363911
Add tests for #34784
wesleywiser Jul 20, 2018
296a179
break --subsystem=x into 2 args; closer to former presumably known-go…
alecmocatta Jul 24, 2018
63ed6a1
Add test for #33264
wesleywiser Jul 24, 2018
bbbbf2d
Add run-pass test for #44005
wesleywiser Jul 20, 2018
8c5ef0a
Add compile-fail test for #42060
wesleywiser Jul 20, 2018
3290774
Add compile-fail test for #43196
wesleywiser Jul 20, 2018
715005c
Update compile-fail tests to be ui tests
wesleywiser Jul 20, 2018
27c0d56
Mark the suggestion applicable
csmoe Jul 23, 2018
a71deb2
Fix ui test
csmoe Jul 24, 2018
9808f7c
update the stdsimd submodule
japaric Jul 24, 2018
f487e39
Add documentation for `Parser::arg_places`
estebank Jul 24, 2018
f9e3762
Reword missing formatting arguments label
estebank Jul 24, 2018
75d2226
Impl Executor for Box<E: Executor>
tinaun Jul 24, 2018
4d8aa59
Use suggestions for `printf` format
estebank Jul 24, 2018
9492176
Suggest in separate line
csmoe Jul 25, 2018
e8bc064
Add regression test for issue #18804
yodaldevoid Jul 23, 2018
a20262c
Properly set the linkage type on non-local statics
yodaldevoid Jul 22, 2018
0bcbe91
Deduplicate linkage checking code for statics
yodaldevoid Jul 23, 2018
e58e7b0
Disable regression test for issue #18804 on Emscripten and Asmjs
yodaldevoid Jul 24, 2018
40c0339
Fix test
csmoe Jul 25, 2018
d5256b7
Update comment and do suggest
csmoe Jul 25, 2018
1d79588
Update ui test
csmoe Jul 25, 2018
3298b9f
Fix unittest
estebank Jul 25, 2018
7bd94e0
Rename method and remove commented out code
estebank Jul 25, 2018
9a893cc
Add span label for format str missing specifier
estebank Jul 25, 2018
580f437
ARM: expose `rclass` and `dsp` target features
paoloteti Jul 25, 2018
f653bf4
Improve readability in a few sorts
ljedrz Jul 25, 2018
ef5fba0
Hide some lints which are not quite right the way they are reported t…
oli-obk Jul 25, 2018
eacfd72
Clarify what a task is
MajorBreakfast Jul 22, 2018
be5b668
Place the ignore comments in the correct file for test issue-18804
yodaldevoid Jul 25, 2018
abb704e
State default capacity for BufReader/BufWriter
fintelia Jul 25, 2018
bce8a91
std::ops::Try impl for std::task::Poll
cramertj Jul 26, 2018
f069a57
rustc: Register crates under their real names
alexcrichton Jul 26, 2018
051eddd
sparc ABI issue - structure returning from function is returned
psumbera Jul 26, 2018
cc2bd71
Add a test for sparc64 ABI issue
nagisa Jul 26, 2018
e29f15b
Rollup merge of #52558 - wesleywiser:ice_melting, r=estebank
Mark-Simulacrum Jul 26, 2018
0127704
Rollup merge of #52610 - MajorBreakfast:task-terminology, r=cramertj
Mark-Simulacrum Jul 26, 2018
2aeb765
Rollup merge of #52617 - matthewjasper:remove-unused-code, r=nikomats…
Mark-Simulacrum Jul 26, 2018
c7555ce
Rollup merge of #52635 - yodaldevoid:issue_18804, r=oli-obk
Mark-Simulacrum Jul 26, 2018
662fb06
Rollup merge of #52647 - csmoe:closure_arg_ignore, r=estebank
Mark-Simulacrum Jul 26, 2018
2aec4e8
Rollup merge of #52649 - estebank:fmt-span, r=oli-obk
Mark-Simulacrum Jul 26, 2018
9f91195
Rollup merge of #52654 - alecmocatta:master, r=alexcrichton
Mark-Simulacrum Jul 26, 2018
007177c
Rollup merge of #52667 - japaric:stdsimd-up, r=alexcrichton
Mark-Simulacrum Jul 26, 2018
7c09bab
Rollup merge of #52674 - tinaun:patch-2, r=cramertj
Mark-Simulacrum Jul 26, 2018
37835be
Rollup merge of #52690 - paoloteti:rclass-dsp, r=alexcrichton
Mark-Simulacrum Jul 26, 2018
55fa4c7
Rollup merge of #52692 - ljedrz:sort_improvements, r=petrochenkov
Mark-Simulacrum Jul 26, 2018
cc7a826
Rollup merge of #52695 - oli-obk:const_err_panic, r=petrochenkov
Mark-Simulacrum Jul 26, 2018
091a10e
Rollup merge of #52718 - fintelia:patch-2, r=cramertj
Mark-Simulacrum Jul 26, 2018
858adfe
Rollup merge of #52721 - cramertj:try-poll, r=aturon
Mark-Simulacrum Jul 26, 2018
d1e549c
Rollup merge of #52723 - alexcrichton:fix-extern-rename-ice, r=estebank
Mark-Simulacrum Jul 26, 2018
995d719
Rollup merge of #52734 - nagisa:sparcfix, r=oli-obk
Mark-Simulacrum Jul 26, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/librustc_metadata/creader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,12 @@ impl<'a> CrateLoader<'a> {
fn register_crate(&mut self,
root: &Option<CratePaths>,
ident: Symbol,
name: Symbol,
span: Span,
lib: Library,
dep_kind: DepKind)
-> (CrateNum, Lrc<cstore::CrateMetadata>) {
info!("register crate `extern crate {} as {}`", name, ident);
let crate_root = lib.metadata.get_root();
info!("register crate `extern crate {} as {}`", crate_root.name, ident);
self.verify_no_symbol_conflicts(span, &crate_root);

// Claim this crate number and cache it
Expand Down Expand Up @@ -233,7 +232,7 @@ impl<'a> CrateLoader<'a> {
.collect();

let cmeta = cstore::CrateMetadata {
name,
name: crate_root.name,
extern_crate: Lock::new(None),
def_path_table: Lrc::new(def_path_table),
trait_impls,
Expand Down Expand Up @@ -328,7 +327,7 @@ impl<'a> CrateLoader<'a> {
(cnum, data)
}
LoadResult::Loaded(library) => {
self.register_crate(root, ident, name, span, library, dep_kind)
self.register_crate(root, ident, span, library, dep_kind)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
-include ../tools.mk

all:
$(RUSTC) foo.rs
$(RUSTC) bar.rs
$(RUSTC) baz.rs --extern a=$(TMPDIR)/libfoo.rlib

13 changes: 13 additions & 0 deletions src/test/run-make-fulldeps/extern-flag-rename-transitive/bar.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_type = "rlib"]

extern crate foo;
14 changes: 14 additions & 0 deletions src/test/run-make-fulldeps/extern-flag-rename-transitive/baz.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_type = "rlib"]

extern crate a;
extern crate bar;
11 changes: 11 additions & 0 deletions src/test/run-make-fulldeps/extern-flag-rename-transitive/foo.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_type = "rlib"]