test: Get some tests working on MSVC 32-bit #30168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few tests that either relied on some odd linker behavior or used intrinsics directly instead of the standard library wrappers which account for various linkage differences across platforms. While we're not running these tests yet this touches them up to the point that they should be ready to pass on 32-bit MSVC.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
Looks like I ended up opening #30448 before this landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few tests that either relied on some odd linker behavior or used
intrinsics directly instead of the standard library wrappers which account for
various linkage differences across platforms. While we're not running these
tests yet this touches them up to the point that they should be ready to pass on
32-bit MSVC.