Rollup of 11 pull requests #27658
Merged
Rollup of 11 pull requests #27658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous wording was confusing. While would we need to go through the whole list just to find the first code point? `chars()` being an iterator, we only need to walk from the beginning of the list.
The "nth" element can be confusing. In an array context, we know indexes start from 0 but one may believe this is not the case with "nth". For example, would `.nth(1)` return the first (1th/1st) or the second element? Rephrase a bit to be less confusing.
This is in line with other targets. Closes rust-lang#27646
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1000 |
|
📌 Commit d5ac535 has been approved by |
|
⌛ Testing commit d5ac535 with merge 30af427... |
|
💔 Test failed - auto-mac-64-opt |
|
This failure was caused due to a 'race condition', after I removed '--crate-type=lib` from pretty test and fixed the resulting failures, a new pretty test was added which broke the build. I'll fix that now. cc #27571 |
|
I updated my original pr to account for the added test, it should build now. |
…sagew, r=alexcrichton
`FormatMessageW` always inserts trailing `\r\n` to system messages which is a minor annoyance when they're fed to `Debug` but can break formatting with `Display`.
```rust
fn main() {
use std::env;
if let Err(err) = env::set_current_dir("???") {
println!("{:#?}\n{}", err, err);
}
}
```
```_
Error {
repr: Os {
code: 2,
message: "The system cannot find the file specified.\r\n"
}
}
The system cannot find the file specified.
(os error 2)
```
…r, r=steveklabnik The previous wording was confusing. While would we need to go through the whole list just to find the first code point? `chars()` being an iterator, we only need to walk from the beginning of the list. Note that I am not a native English speaker and I have still difficulties to spot if a "the" is needed somewhere. Feel free to take this PR as a mere suggestion. r? @steveklabnik
…teveklabnik The "nth" element can be confusing. In an array context, we know indexes start from 0 but one may believe this is not the case with "nth". For example, would `.nth(1)` return the first (1th/1st) or the second element? Rephrase a bit to be less confusing. r? @steveklabnik
…arth As title :-) Part of rust-lang#24407. r? @Manishearth
This is in line with other targets. Closes rust-lang#27646
|
@bors r+ p=100 force |
|
📌 Commit aebd6d5 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chars().nth()work #27611, doc/core: fix description ofnthfunction #27612, add diagnostics for E0193 #27617, doc: add missing symbol #27633, Use pentium4 for base CPU on i686-pc-windows-msvc #27647, doc: successful deletion should be implied #27648, doc: remove an unneeded distinction #27651