Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide: Hello world #15181

Closed
wants to merge 4 commits into from
Closed

Conversation

steveklabnik
Copy link
Member

This is built on top of #15162 . steveklabnik@cccae83 is the only new commit, you may want to look at that rather than the whole diff.

Writing our first Rust program together. This is the most crucial step, so I go to a fairly deep level of detail. Future sections will move more quickly.

@steveklabnik steveklabnik mentioned this pull request Jun 25, 2014
bors added a commit that referenced this pull request Jun 26, 2014
This is built on top of #15162 . steveklabnik@cccae83 is the only new commit, you may want to look at that rather than the whole diff.

Writing our first Rust program together. This is the most crucial step, so I go to a fairly deep level of detail. Future sections will move more quickly.
@bors bors closed this Jun 26, 2014
@steveklabnik steveklabnik deleted the hello_world branch June 26, 2014 17:17
@steveklabnik
Copy link
Member Author

@brson do you know when this will be reflected in http://doc.rust-lang.org/guide.html ? Normally it happens quite quickly.

@alexcrichton
Copy link
Member

Each night when the nightlies are built they upload documentation as well. Basically, every morning at 5am-ish the docs get updated.

@steveklabnik
Copy link
Member Author

Ahh awesome. 👍

bors added a commit that referenced this pull request Jun 27, 2014
Built on top of #15181. steveklabnik@e527192 is the only new commit, you may want to review that separately.

I'm not sure if the car analogy is too glib.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2023
…=Veykril

Clean up `ImportMap`

There are several things in `hir_def::import_map` that are never used. This PR removes them and restructures the code. Namely:

- Removes `Query::name_only`, because it's *always* true.
  - Because of this, we never took advantage of storing items' full path. This PR removes `ImportPath` and changes `ImportInfo` to only store items' name, which should reduce the memory consumption to some extent.
- Removes `SearchMode::Contains` for `Query` because it's never used.
- Merges `Query::assoc_items_only` and `Query::exclude_import_kinds` into `Query::assoc_mode`, because the latter is never used besides filtering associated items out.

Best reviewed one commit at a time. I made sure each commit passes full test suite. I can squash the first three commits if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants