[beta] Clippy beta backport #136982
Closed
[beta] Clippy beta backport #136982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `-Cstrip` was changed to use the bundled rust-objcopy instead of /usr/bin/strip on OSX, strip-like arguments were preserved. But strip and objcopy are, while being the same binary, different, they have different defaults depending on which binary they are. Notably, strip strips everything by default, and objcopy doesn't strip anything by default. Additionally, `-S` actually means `--strip-all`, so debuginfo stripped everything and symbols didn't strip anything. We now correctly pass `--strip-debug` and `--strip-all`.
This reverts commit 2316749.
This reverts commit f5577a8.
Prepare 1.85 beta release r? `@ghost`
potential violations (cherry picked from commit 045271c)
(cherry picked from commit 34edb21)
Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com> (cherry picked from commit 13c7122)
…checking (cherry picked from commit 197f6d8)
(cherry picked from commit 4a099b2)
(cherry picked from commit c55eefe)
[beta] stage0 bump and backports - bump stage0 to 1.84.0 - Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations rust-lang#134523 r? cuviper
This incorporates all the backwards-compatible changes for the 2024 Edition. There will also be a follow-on PR to land revisions to the new chapter on async so it can be as ready as possible when officially released with 1.85 and the 2024 Edition. Additionally, there are a few other, non-backward-compatible, changes (largely around `use<..>`) we can only land using the stable edition, which we may or may not be able to land in 1.85 by using the beta toolchain in the example code. Those may or may not be ported over, depending on how that does or does not play with the infrastructure.
It has been a bit of a pain trying to keep the lints in sync across the submodule repositories, so the just turns it off.
The implementation is unsound when a partially consumed iterator has some elements buffered in the front/back parts and cloning the Iterator removes the capacity from the backing vec::IntoIter. (cherry picked from commit 3d871b3)
(cherry picked from commit 1ed0ea4)
(cherry picked from commit 1b068a0)
(cherry picked from commit a40c659)
…ehuss [beta] TRPL: incorporate all backward-compatible Edition changes This incorporates all the backwards-compatible changes for the 2024 Edition. There will also be a follow-on PR to land revisions to the new chapter on async so it can be as ready as possible when officially released with 1.85 and the 2024 Edition. Additionally, there are a few other, non-backward-compatible, changes (largely around `use<..>`) we can only land using the stable edition, which we may or may not be able to land in 1.85 by using the beta toolchain in the example code. Those may or may not be ported over, depending on how that does or does not play with the infrastructure. This is identical to rust-lang#135507 except that this targets `beta` instead of `master`, with the intent that these changes land in 1.85 and go out with the Edition release.
[beta] backports - do not in-place-iterate over flatmap/flatten rust-lang#135104 - Make sure to mark `IMPL_TRAIT_REDUNDANT_CAPTURES` as `Allow` in edition 2024 rust-lang#135441 - Update to LLVM 19.1.7 rust-lang#135484 r? cuviper
Creating a "trimmed DefID path" when no error is being emitted is an ICE (on purpose). If we create a trimmed path for a lint that is then silenced before being emitted causes a known ICE. This side-steps the issue by always using `with_no_trimmed_path!`. This was verified to fix /~https://github.com/quinn-rs/quinn/, but couldn't write a repro case for the test suite. Fix rust-lang#135289. (cherry picked from commit 93a1950)
(cherry picked from commit 7d80617)
There is a chance that these tools are being installed from an external LLVM and we have no control over them. If any of these tools use symlinks, they will fail during tarball distribution. This change makes copying process to resolve symlinks just before placing them into the destination path. Signed-off-by: onur-ozkan <work@onurozkan.dev> (cherry picked from commit cde58dd)
(cherry picked from commit ebbcfd4)
(cherry picked from commit c69dea9)
(cherry picked from commit 2c778c1)
(cherry picked from commit 94562ee)
We want kernels to be able to use this bare metal target, so let's enable the sanitizers that kernels want to use. (cherry picked from commit 6b06aa6)
[beta] backports - Ensure that we don't try to access fields on a non-struct pattern type rust-lang#135222 - Do not include GCC source code in source tarballs rust-lang#135658 - Temporarily bring back `Rvalue::Len` rust-lang#135709 - Add a couple of missing `ensure_sufficient_stacks` rust-lang#136352 - Enable kernel sanitizers for aarch64-unknown-none-softfloat rust-lang#135905 r? cuviper
…rust-lang#14014) This PR changes literal_string_with_formatting_args category from `suspicious` to `nursery` since there are thousands of false positive on GitHub. Closes rust-lang#13989 since it's no longer problematic with such false positive with ~~`pedantic`~~ `nursery` category. changelog: [`literal_string_with_formatting_args` ] change category to `nursery` from `suspicious`
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
the
S-waiting-on-review
|
r+ clippy side |
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
|
@bors p=1 to hopefully get in before the release PR |
|
@bors p=10 |
|
@bors r- I need to start the branch moves, and I don't want this in flight when that happens. It's a trivial change though, so I expect I can pull it into the stable PR without trouble. |
bors
added
S-waiting-on-author
promote-release
bot
force-pushed
the
beta
branch
from
461de74 to
9cd60bd
Compare
|
☔ The latest upstream changes (presumably #137057) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2025
Prepare Rust 1.85.0 stable release This includes a relnotes sync and a few last-minute backports: - change `literal_string_with_formatting_args` lint category to nursery rust-lang#136982 - Update the reference for reverted `extended_varargs_abi_support` rust-lang#136934 - fix musl's CVE-2025-26519 rust-lang#137127 r? cuviper
|
Included in #137181. |
cuviper
added
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
literal_string_with_formatting_argslint category to nursery rust-clippy#14014This lint was added in the prior release cycle, but has too many FPs to hit stable. On
masterit is already in thenurserygroup. Let's also move it there inbeta, so that the FPs don't show up on stable 1.85.r? @Mark-Simulacrum