-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten linker output even more when --verbose
is not present
#135707
base: master
Are you sure you want to change the base?
Conversation
This PR modifies cc @jieyouxu Some changes occurred in src/tools/compiletest cc @jieyouxu The run-make-support library was changed cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
f5a75ee
to
89ffd82
Compare
This comment has been minimized.
This comment has been minimized.
89ffd82
to
9c01e98
Compare
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
dual-licensed as mit and apache: /~https://github.com/BurntSushi/bstr/blob/master/Cargo.toml#L11 |
This comment has been minimized.
This comment has been minimized.
9c01e98
to
e4dc304
Compare
This comment has been minimized.
This comment has been minimized.
e4dc304
to
67991b4
Compare
This comment has been minimized.
This comment has been minimized.
67991b4
to
ab440b5
Compare
This comment has been minimized.
This comment has been minimized.
ab440b5
to
503b146
Compare
This comment has been minimized.
This comment has been minimized.
- Don't show environment variables. Seeing PATH is almost never useful, and it can be extremely long. - For .rlibs in the sysroot, replace crate hashes with a `"-*"` string. This will expand to the full crate name when pasted into the shell. - Move `.rlib` to outside the glob. - Abbreviate the sysroot path to `<sysroot>` wherever it appears in the arguments. This also adds an example of the linker output as a run-make test. Currently it only runs on x86_64-unknown-linux-gnu, because each platform has its own linker arguments. So that it's stable across machines, pass BUILD_ROOT as an argument through compiletest through to run-make tests.
503b146
to
557b1f8
Compare
This is ready for review. |
"-*"
string. This will expand to the full crate name when pasted into the shell..rlib
to outside the glob.<sysroot>
wherever it appears in the arguments.This also adds an example of the linker output as a run-make test. Currently it only runs on x86_64-unknown-linux-gnu, because each platform has its own linker arguments. So that it's stable across machines, pass BUILD_ROOT as an argument through compiletest through to run-make tests.
r? @bjorn3