Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make -O mean OptLevel::Aggressive #135439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make -O mean OptLevel::Aggressive #135439

wants to merge 1 commit into from
+38 −33

Conversation

clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 13, 2025 •
edited
Loading

Just out of curiosity to see if anything is relying on this
MCP: rust-lang/compiler-team#828

This also renames OptLevel::Default to OptLevel::More, as Default no longer makes sense

r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2025
@clubby789 clubby789 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2025
@clubby789 clubby789 marked this pull request as draft January 13, 2025 15:53
@clubby789
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 13, 2025

⌛ Trying commit 99d3f7a with merge 1d1ae32...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2025
@bors
Auto merge of rust-lang#135439 - clubby789:O3, r=<try>
1d1ae32 
[EXPERIMENTAL] Make `-O` mean `OptLevel::Aggressive`

Just out of curiosity to see if anything is relying on this

r? ghost
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jan 13, 2025

☀️ Try build successful - checks-actions
Build commit: 1d1ae32 (1d1ae328d71e07352118cafffcf33b01a88b6631)

@clubby789
Copy link
Contributor Author

Will keep this open in case rust-lang/compiler-team#828 merges

@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 14, 2025
@clubby789 clubby789 added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed A-run-make Area: port run-make Makefiles to rmake.rs labels Jan 14, 2025
@clubby789 clubby789 changed the title [EXPERIMENTAL] Make -O mean OptLevel::Aggressive Make -O mean OptLevel::Aggressive Jan 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clubby789 clubby789 removed the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Jan 16, 2025
@clubby789 clubby789 marked this pull request as ready for review January 16, 2025 13:53
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Noratrieb
Noratrieb reviewed Jan 19, 2025
View reviewed changes
compiler/rustc_session/src/config.rs
Aggressive, // -O3
Size, // -Os
SizeMin, // -Oz
/// `-O0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// `-O0`
/// `-Copt-level=0`

these flags do not exist, let's name them correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

Assignees
No one assigned
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clubby789 @bors @rust-log-analyzer @rustbot @Noratrieb