Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trait definition cycle detection for trait alias definitions, too #134504

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 19, 2024

fixes #133901

In general doing this for All is not right, but this code path is specifically for traits and trait aliases, and there we only ever use All for trait aliases.

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2024
@oli-obk oli-obk changed the title Use trait defintion cycle detection for trait alias definitions, too Use trait definition cycle detection for trait alias definitions, too Dec 19, 2024
`Ty::new` wasn't used anywhere outside this module

`Ty::new_adt` shouldn't ever be used for anything but adts. This hasn't caught any bugs, but seems good to check anyway
@oli-obk oli-obk force-pushed the push-rltsvnyttwll branch from 6348c8f to 37f2998 Compare January 9, 2025 09:24
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2025

📌 Commit 37f2998 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2025
@compiler-errors
Copy link
Member

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jan 16, 2025

⌛ Testing commit 37f2998 with merge 99db273...

@bors
Copy link
Contributor

bors commented Jan 16, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 99db273 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 16, 2025
@bors bors merged commit 99db273 into rust-lang:master Jan 16, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 16, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (99db273): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.0%, secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 2
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

Cycles

Results (secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.031s -> 765.311s (0.30%)
Artifact size: 326.06 MiB -> 326.02 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang from infinitely-self-recursive trait alias
5 participants