-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use trait definition cycle detection for trait alias definitions, too #134504
Conversation
rustbot has assigned @compiler-errors. Use |
97a1966
to
6348c8f
Compare
`Ty::new` wasn't used anywhere outside this module `Ty::new_adt` shouldn't ever be used for anything but adts. This hasn't caught any bugs, but seems good to check anyway
6348c8f
to
37f2998
Compare
@bors r+ |
@bors rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (99db273): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.0%, secondary -1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.031s -> 765.311s (0.30%) |
fixes #133901
In general doing this for
All
is not right, but this code path is specifically for traits and trait aliases, and there we only ever useAll
for trait aliases.