-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always structurally resolve coercion target #131483
Conversation
This comment has been minimized.
This comment has been minimized.
39b5936
to
95e2707
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Always structurally resolve coercion target This is morally a no-op. We have a few callsites that manually call `resolve_vars_with_obligations` before coercion, so let's not do that and just always structurally resolve in the coerce function itself. r? lcnr
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (3976ff6): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 0.1%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.605s -> 775.687s (0.14%) |
2893936
to
234cb7b
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Always structurally resolve coercion target This is morally a no-op. We have a few callsites that manually call `resolve_vars_with_obligations` before coercion, so let's not do that and just always structurally resolve in the coerce function itself. r? lcnr
The job Click to see the possible cause of the failure (guessed by this bot)
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #131948) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm gonna close this for now since it only affects |
This is morally a no-op. We have a few callsites that manually call
resolve_vars_with_obligations
before coercion, so let's not do that and just always structurally resolve in the coerce function itself.r? lcnr