-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ptr metadata functions callable from stable const fn #130966
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #![feature(staged_api, rustc_attrs, intrinsics)] | ||
| #![stable(since="1.0.0", feature = "stable")] | ||
|
|
||
| extern "rust-intrinsic" { | ||
| #[unstable(feature = "unstable", issue = "42")] | ||
| #[rustc_const_stable(feature = "stable", since = "1.0.0")] | ||
| #[rustc_nounwind] | ||
| pub fn write_bytes<T>(dst: *mut T, val: u8, count: usize); | ||
| } | ||
|
|
||
| #[unstable(feature = "unstable", issue = "42")] | ||
| #[rustc_const_stable(feature = "stable", since = "1.0.0")] | ||
| pub const fn some_unstable_fn() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| //@ aux-build:unstable_but_const_stable.rs | ||
|
|
||
| extern crate unstable_but_const_stable; | ||
| use unstable_but_const_stable::*; | ||
|
|
||
| fn main() { | ||
| some_unstable_fn(); //~ERROR use of unstable library feature | ||
| unsafe { write_bytes(4 as *mut u8, 0, 0) }; //~ERROR use of unstable library feature | ||
| } | ||
|
|
||
| const fn const_main() { | ||
| some_unstable_fn(); //~ERROR use of unstable library feature | ||
| unsafe { write_bytes(4 as *mut u8, 0, 0) }; //~ERROR use of unstable library feature | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| error[E0658]: use of unstable library feature 'unstable' | ||
| --> $DIR/unstable-const-stable.rs:7:5 | ||
| | | ||
| LL | some_unstable_fn(); | ||
| | ^^^^^^^^^^^^^^^^ | ||
| | | ||
| = note: see issue #42 </~https://github.com/rust-lang/rust/issues/42> for more information | ||
| = help: add `#![feature(unstable)]` to the crate attributes to enable | ||
| = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
|
|
||
| error[E0658]: use of unstable library feature 'unstable' | ||
| --> $DIR/unstable-const-stable.rs:8:14 | ||
| | | ||
| LL | unsafe { write_bytes(4 as *mut u8, 0, 0) }; | ||
| | ^^^^^^^^^^^ | ||
| | | ||
| = note: see issue #42 </~https://github.com/rust-lang/rust/issues/42> for more information | ||
| = help: add `#![feature(unstable)]` to the crate attributes to enable | ||
| = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
|
|
||
| error[E0658]: use of unstable library feature 'unstable' | ||
| --> $DIR/unstable-const-stable.rs:12:5 | ||
| | | ||
| LL | some_unstable_fn(); | ||
| | ^^^^^^^^^^^^^^^^ | ||
| | | ||
| = note: see issue #42 </~https://github.com/rust-lang/rust/issues/42> for more information | ||
| = help: add `#![feature(unstable)]` to the crate attributes to enable | ||
| = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
|
|
||
| error[E0658]: use of unstable library feature 'unstable' | ||
| --> $DIR/unstable-const-stable.rs:13:14 | ||
| | | ||
| LL | unsafe { write_bytes(4 as *mut u8, 0, 0) }; | ||
| | ^^^^^^^^^^^ | ||
| | | ||
| = note: see issue #42 </~https://github.com/rust-lang/rust/issues/42> for more information | ||
| = help: add `#![feature(unstable)]` to the crate attributes to enable | ||
| = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
|
|
||
| error: aborting due to 4 previous errors | ||
|
|
||
| For more information about this error, try `rustc --explain E0658`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, seems odd to mark this as const-stable when it's not normal-stable? I don't remember use doing that elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is precedent for that: the
raw_vec_internals_constfeature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another example: #128228 (comment). tbh it also feels surprising to me 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we should redo how we do const stability. See #129815.
But for now this is the system that we got.