-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate jobserver-error
run-make
test to rmake
#128789
Conversation
This comment has been minimized.
This comment has been minimized.
484fa0e
to
97091f2
Compare
77c21c5
to
6b3c4c2
Compare
This comment has been minimized.
This comment has been minimized.
6b3c4c2
to
8816029
Compare
This comment has been minimized.
This comment has been minimized.
8816029
to
6f67fa0
Compare
6f67fa0
to
482fa51
Compare
This PR modifies cc @jieyouxu The run-make-support library was changed cc @jieyouxu |
☔ The latest upstream changes (presumably #131917) made this pull request unmergeable. Please resolve the merge conflicts. |
FWIW, we might actually just delete the disabled part of this test cc #110321.
|
Thanks for the PR, this is superseded by #135461 (with attribution to both authors). |
…=<try> tests: Port `jobserver-error.rs` to rmake.rs Part of rust-lang#121876. This PR ports `jobserver-error.rs` to rmake.rs, and is basically rust-lang#128789 slightly adjusted. Namely, `set_aux_fd` is made `unsafe`, alongside some doc updates. The complexity involved here is mostly how to get `/dev/null/` piping to fd 3 working with std `Command`, whereas with a shell this is much easier (as is evident with the `Makefile` version). Supersedes rust-lang#128789. This PR is co-authored with `@Oneirical` and `@coolreader18.` r? `@ghost` try-job: aarch64-gnu try-job: i686-gnu-1 try-job: x86_64-gnu-debug try-job: x86_64-gnu-llvm-18-1
…=<try> tests: Port `jobserver-error` to rmake.rs Part of rust-lang#121876. This PR ports `tests/run-make/jobserver-error` to rmake.rs, and is basically rust-lang#128789 slightly adjusted. Namely, `set_aux_fd` is made `unsafe`, alongside some doc updates. The complexity involved here is mostly how to get `/dev/null/` piping to fd 3 working with std `Command`, whereas with a shell this is much easier (as is evident with the `Makefile` version). Supersedes rust-lang#128789. This PR is co-authored with `@Oneirical` and `@coolreader18.` r? `@ghost` try-job: aarch64-gnu try-job: i686-gnu-1 try-job: x86_64-gnu-debug try-job: x86_64-gnu-llvm-18-1
Part of #121876 and the associated Google Summer of Code project.
In a similar fashion to #128460, this test contains peculiar interactions with the
/dev/
directory and piping to file descriptors. Note the massive commented section, which requires figuring out how to pipe/dev/null/
to file descriptor3
to get this to work.Will need try jobs, but not yet.