-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo #108330
Update cargo #108330
Conversation
These commits modify the If this was intentional then you can ignore this comment. Some changes occurred in src/tools/cargo cc @ehuss |
Lockfile change looks reasonable and expected. @bors r+ p=1 |
📌 Commit 391a243d6b3695631cd8f333b5ea1f9fd1b296d9 has been approved by It is now in the queue for this repository. |
I think we should wait for curl to release curl/curl@821f6e2, and update curl-sys to prevent rust-lang/cargo#11746. |
⌛ Testing commit 391a243d6b3695631cd8f333b5ea1f9fd1b296d9 with merge a5493c220346b834c479119a0a356717fd6c1c3e... |
Valid. @bors r- |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
15 commits in 17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6..9d5b32f503fc099c4064298465add14d4bce11e6 2023-02-17 19:45:09 +0000 to 2023-02-22 23:04:16 +0000 - refactor(job_queue): docs and move types around (rust-lang/cargo#11758) - Scrub more of the test environment (rust-lang/cargo#11757) - Make more reads of environment variables go through the `Config` (rust-lang/cargo#11754) - Revert "Update curl-sys to use libcurl 7.88.1" (rust-lang/cargo#11755) - use consistent case (rust-lang/cargo#11748) - Switch some tests from `build` to `check` (rust-lang/cargo#11725) - Fix typo in sparse-registry warning message (rust-lang/cargo#11753) - reuse url encoding from `url` crate, don't use separate `percent-encoding` (rust-lang/cargo#11750) - Read environment variables through `Config` instead of `std::env::var(_os)` (rust-lang/cargo#11727) - Update curl-sys to use libcurl 7.88.1 (rust-lang/cargo#11749) - mdman: update pretty_assertions to reduce deps (rust-lang/cargo#11747) - Cleanup tests (rust-lang/cargo#11745) - Enhance help texts of position args (rust-lang/cargo#11740) - Fix typo (rust-lang/cargo#11741) - Update comment about cargo-ok (rust-lang/cargo#11724)
391a243
to
80bea6c
Compare
curl has been reverted. @bors r+ p=1 |
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
Finished benchmarking commit (8b1dbf7): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Clearly noise, when getting perf changes from a cargo update. @rustbot label: +perf-regression-triaged |
15 commits in 17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6..9d5b32f503fc099c4064298465add14d4bce11e6
2023-02-17 19:45:09 +0000 to 2023-02-22 23:04:16 +0000
Config
(Make more reads of environment variables go through theConfig
cargo#11754)build
tocheck
(Switch some tests frombuild
tocheck
cargo#11725)url
crate, don't use separatepercent-encoding
(reuse url encoding fromurl
crate, don't use separatepercent-encoding
cargo#11750)Config
instead ofstd::env::var(_os)
(Read environment variables throughConfig
instead ofstd::env::var(_os)
cargo#11727)