Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hir-analysis: make one diagnostic translatable #108323

Merged
merged 1 commit into from
Feb 22, 2023
Merged

hir-analysis: make one diagnostic translatable #108323

merged 1 commit into from
Feb 22, 2023

Conversation

tshepang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 21, 2023

📌 Commit b483816 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned nagisa Feb 21, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2023
@bors
Auto merge of rust-lang#108325 - matthiaskrgr:rollup-73qihie, r=matth…
f9216b7 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104239 (Better debug logs for borrowck constraint graph)
 - rust-lang#108202 (Make sure `test_type_match` doesn't ICE with late-bound types)
 - rust-lang#108295 (Use DefKind to give more item kind information during BindingObligation note )
 - rust-lang#108306 (compiletest: up deps)
 - rust-lang#108313 (Fix compiletest possible crash in option only-modified)
 - rust-lang#108322 (Clean ConstProp)
 - rust-lang#108323 (hir-analysis: make one diagnostic translatable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d39fc21 into rust-lang:master Feb 22, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 22, 2023
@tshepang tshepang deleted the translatable-hir-analysis branch February 22, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @compiler-errors @bors @nagisa