Rollup of 8 pull requests #106588
Merged
Rollup of 8 pull requests #106588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Stabilize `main_separator_str` See reasoning here: rust-lang#94071 (comment). Closes rust-lang#94071.
…-diag, r=compiler-errors Suggest `mut self: &mut Self` for `?Sized` impls Closes rust-lang#106325 Closes rust-lang#93078 The suggestion is _probably_ not what the user wants (hence `MaybeIncorrect`) but at least makes the problem in the above issues clearer. It might be better to add a note explaining why this is the case, but I'm not sure how best to word that so this is a start. ``@rustbot`` label +A-diagnostics
Adjust comments about pre-push.sh hook Follow-up to rust-lang#101175.
…al-item, r=notriddle jsondoclint: Check local items in `paths` are also in `index`. Would have caught rust-lang#104064 (if core.json was linted in CI). Closes rust-lang#106433. r? rustdoc
…aumeGomez Add some UI tests and reword error-code docs Added UI tests for `E0013` and `E0015`. Error code docs for `E0015` were a bit unclear (they referred to all non-const errors in const context, when only non-const functions applied), so I touched them up a bit. I also fixed up some issues in the new `error_codes.rs` tidy check (linked rust-lang#106341), that I overlooked previously. r? ``@GuillaumeGomez``
…k-Simulacrum Clarify examples for `VecDeque::get/get_mut` Closes rust-lang#106114 ``@rustbot`` label +A-docs
…errors remove unreachable error code `E0313` Fixes rust-lang#103742 Makes rust-lang#103433 redundant Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing? Also removed a redundant `// ignore-tidy-filelength` that I found while reading code. cc ``@GuillaumeGomez`` rust-lang#61137
…r-errors Do not emit wrong E0308 suggestion for closure mismatch Found in rust-lang#76353.
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 2afe58571e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (8ea62f6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
main_separator_str#103104 (Stabilizemain_separator_str)mut self: &mut Selffor?Sizedimpls #106410 (Suggestmut self: &mut Selffor?Sizedimpls)pathsare also inindex. #106546 (jsondoclint: Check local items inpathsare also inindex.)VecDeque::get/get_mut#106562 (Clarify examples forVecDeque::get/get_mut)E0313#106580 (remove unreachable error codeE0313)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup