Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make encode_attrs use queries instead of accessing the HIR #105496

Closed
wants to merge 1 commit into from
Closed

Make encode_attrs use queries instead of accessing the HIR #105496

wants to merge 1 commit into from

Conversation

spastorino
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 9, 2022
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 9, 2022
@bors
Copy link
Contributor

bors commented Dec 9, 2022

⌛ Trying commit 6bd99422d5c5b77509889ddb36e4f49e94085bdc with merge 42639c1883feafb98335b2fa3170f5d6d19e2243...

@bors
Copy link
Contributor

bors commented Dec 9, 2022

☀️ Try build successful - checks-actions
Build commit: 42639c1883feafb98335b2fa3170f5d6d19e2243 (42639c1883feafb98335b2fa3170f5d6d19e2243)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (42639c1883feafb98335b2fa3170f5d6d19e2243): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.2%, 2.2%] 89
Regressions ❌
(secondary)		 1.0% [0.1%, 2.6%] 33
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) 0.8% [0.2%, 2.2%] 89

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.5% [0.5%, 4.3%] 24
Regressions ❌
(secondary)		 1.3% [1.1%, 1.5%] 4
Improvements ✅
(primary)		 -0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.4% [-0.8%, 4.3%] 25

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.7% [1.3%, 2.5%] 6
Regressions ❌
(secondary)		 2.7% [1.4%, 3.5%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.7% [1.3%, 2.5%] 6

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 9, 2022
@spastorino spastorino force-pushed the make-encoder-use-queries-2 branch from 6bd9942 to 39a655d Compare December 12, 2022 15:35
@oli-obk
Copy link
Contributor

oli-obk commented Dec 12, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 12, 2022
@bors
Copy link
Contributor

bors commented Dec 12, 2022

⌛ Trying commit 39a655dda9b387493955892da5ccb6ad6d0fa865 with merge af41bb0f5f21e61802daafb28352c5cc79eb9d22...

@bors
Copy link
Contributor

bors commented Dec 12, 2022

☀️ Try build successful - checks-actions
Build commit: af41bb0f5f21e61802daafb28352c5cc79eb9d22 (af41bb0f5f21e61802daafb28352c5cc79eb9d22)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (af41bb0f5f21e61802daafb28352c5cc79eb9d22): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.2%, 1.9%] 92
Regressions ❌
(secondary)		 1.0% [0.2%, 2.7%] 44
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) 0.8% [0.2%, 1.9%] 92

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.4% [0.4%, 3.6%] 26
Regressions ❌
(secondary)		 1.5% [1.4%, 1.7%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 1.4% [0.4%, 3.6%] 26

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.2% [2.1%, 2.6%] 3
Regressions ❌
(secondary)		 3.0% [2.2%, 4.2%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.2% [2.1%, 2.6%] 3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 12, 2022
@spastorino
Copy link
Member Author

This previous result #105496 is the result without any attribute on the query.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 13, 2022

There's no attribute on the current run either

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2022

Some changes occurred in src/tools/cargo

cc @ehuss

@spastorino spastorino force-pushed the make-encoder-use-queries-2 branch from 0456c6c to ea8088f Compare December 13, 2022 12:50
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 16, 2022

⌛ Trying commit 29c7d69b50fe5e88270ff1e3add270145006d131 with merge fd3b812a7c6c686f2f3d1f11afaef15402ce7cbd...

@bors
Copy link
Contributor

bors commented Dec 16, 2022

☀️ Try build successful - checks-actions
Build commit: fd3b812a7c6c686f2f3d1f11afaef15402ce7cbd (fd3b812a7c6c686f2f3d1f11afaef15402ce7cbd)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd3b812a7c6c686f2f3d1f11afaef15402ce7cbd): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.2%, 0.9%] 62
Regressions ❌
(secondary)		 0.7% [0.1%, 1.9%] 25
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) 0.5% [0.2%, 0.9%] 62

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.3% [0.4%, 3.4%] 17
Regressions ❌
(secondary)		 2.1% [1.6%, 2.5%] 2
Improvements ✅
(primary)		 -2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)		 -2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) 1.1% [-2.7%, 3.4%] 18

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.7% [1.3%, 2.1%] 2
Regressions ❌
(secondary)		 2.2% [1.6%, 2.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.7% [1.3%, 2.1%] 2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 16, 2022
@spastorino spastorino force-pushed the make-encoder-use-queries-2 branch from 29c7d69 to 5152355 Compare December 17, 2022 02:34
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 17, 2022
@bors
Copy link
Contributor

bors commented Dec 17, 2022

⌛ Trying commit 5152355 with merge e8a114a4e8348e34c1ee33349b41012d8e432bde...

@bors
Copy link
Contributor

bors commented Dec 17, 2022

☀️ Try build successful - checks-actions
Build commit: e8a114a4e8348e34c1ee33349b41012d8e432bde (e8a114a4e8348e34c1ee33349b41012d8e432bde)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e8a114a4e8348e34c1ee33349b41012d8e432bde): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 2
All ❌✅ (primary) - - 0

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Dec 17, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 17, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 17, 2022

📌 Commit 5152355 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 17, 2022

@bors r-

The title is now wrong. And we should probably only land this in an pr that needs it

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2022
@spastorino
Copy link
Member Author

@oli-obk yes, let's close this PR and I can rebase my RPITIT branch on top of this commit.

@spastorino spastorino closed this Dec 17, 2022
@compiler-errors compiler-errors mentioned this pull request Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spastorino @rust-timer @bors @oli-obk @rustbot