commit and message tweaks from review

Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
rust-lang · Jun 26, 2024 · e1e8774 · e1e8774
1 parent b00d875
commit e1e8774
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/compiler/rustc_lint/messages.ftl b/compiler/rustc_lint/messages.ftl
@@ -397,7 +397,7 @@ lint_incomplete_include =
 
 lint_inner_macro_attribute_unstable = inner macro attributes are unstable
 
-lint_invalid_asm_label_binary = avoid using labels containing only the digits 0 and 1 in inline assembly
+lint_invalid_asm_label_binary = avoid using labels containing only the digits `0` and `1` in inline assembly
     .help = use a different number that has at least one digit 2 or greater
     .note = an LLVM bug makes these labels ambiguous with a binary literal number
     .note = see <https://bugs.llvm.org/show_bug.cgi?id=36144> for more information

diff --git a/compiler/rustc_lint/src/builtin.rs b/compiler/rustc_lint/src/builtin.rs
@@ -2903,10 +2903,10 @@ impl<'tcx> LateLintPass<'tcx> for AsmLabels {
                             in_bracket = true;
                             label_kind = AsmLabelKind::FormatArg;
                         } else if matches!(start, '0' | '1') {
-                            // binary labels have only the characters 0 or 1
+                            // Binary labels have only the characters `0` or `1`.
                             label_kind = AsmLabelKind::Binary;
                         } else if !(start.is_ascii_alphabetic() || matches!(start, '.' | '_')) {
-                            // named labels start with ASCII letters or . or _
+                            // Named labels start with ASCII letters, `.` or `_`.
                             // anything else is not a label
                             break 'label_loop;
                         }
@@ -2934,7 +2934,7 @@ impl<'tcx> LateLintPass<'tcx> for AsmLabels {
                                 label_kind = AsmLabelKind::FormatArg;
                             } else {
                                 let can_continue = match label_kind {
-                                    // format arg labels are considered to be named labels for the purposes
+                                    // Format arg labels are considered to be named labels for the purposes
                                     // of continuing outside of their {} pair.
                                     AsmLabelKind::Named | AsmLabelKind::FormatArg => {
                                         c.is_ascii_alphanumeric() || matches!(c, '_' | '$')